linux-kernel - Re: [PATCH 34/44] tty: do not check tty_unregister

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210302111437.GF7604@suse.cz>
Date:   Tue, 2 Mar 2021 12:14:37 +0100
From:   David Sterba <dsterba@...e.cz>
To:     Jiri Slaby <jslaby@...e.cz>
Cc:     gregkh@...uxfoundation.org, linux-serial@...r.kernel.org,
        linux-kernel@...r.kernel.org, Chris Zankel <chris@...kel.net>,
        Max Filippov <jcmvbkbc@...il.com>,
        linux-xtensa@...ux-xtensa.org, Jiri Kosina <jikos@...nel.org>,
        David Sterba <dsterba@...e.com>
Subject: Re: [PATCH 34/44] tty: do not check tty_unregister_driver's return
 value

On Tue, Mar 02, 2021 at 07:22:04AM +0100, Jiri Slaby wrote:
> These drivers check tty_unregister_driver return value. But they don't
> handle a failure correctly (they free the driver in any case). So stop
> checking tty_unregister_driver return value and remove also the prints.
> 
> In the next patch, tty_unregister_driver's return type will be switched
> to void.
> 
> Signed-off-by: Jiri Slaby <jslaby@...e.cz>
> Cc: Chris Zankel <chris@...kel.net>
> Cc: Max Filippov <jcmvbkbc@...il.com>
> Cc: linux-xtensa@...ux-xtensa.org
> Cc: Jiri Kosina <jikos@...nel.org>
> Cc: David Sterba <dsterba@...e.com>
> ---

For

>  drivers/tty/ipwireless/tty.c        | 7 +------

Acked-by: David Sterba <dsterba@...e.com>

Thanks.