linux-kernel - Re: [PATCH] perf trace: Ensure read cmdlines are null terminated.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 2 Mar 2021 09:36:02 -0300
From:   Arnaldo Carvalho de Melo <acme@...nel.org>
To:     Namhyung Kim <namhyung@...nel.org>
Cc:     Ian Rogers <irogers@...gle.com>,
        Peter Zijlstra <peterz@...radead.org>,
        Ingo Molnar <mingo@...hat.com>,
        Mark Rutland <mark.rutland@....com>,
        Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
        Jiri Olsa <jolsa@...hat.com>,
        linux-kernel <linux-kernel@...r.kernel.org>,
        Stephane Eranian <eranian@...gle.com>
Subject: Re: [PATCH] perf trace: Ensure read cmdlines are null terminated.

Em Mon, Mar 01, 2021 at 04:50:50PM +0900, Namhyung Kim escreveu:
> Hi Ian,
> 
> On Sat, Feb 27, 2021 at 7:14 AM Ian Rogers <irogers@...gle.com> wrote:
> >
> > Issue detected by address sanitizer.
> >
> > Fixes: cd4ceb63438e (perf util: Save pid-cmdline mapping into tracing header)
> > Signed-off-by: Ian Rogers <irogers@...gle.com>
> 
> Acked-by: Namhyung Kim <namhyung@...nel.org>

Thanks, applied.

- Arnaldo

 
> Thanks,
> Namhyung
> 
> > ---
> >  tools/perf/util/trace-event-read.c | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/tools/perf/util/trace-event-read.c b/tools/perf/util/trace-event-read.c
> > index f507dff713c9..8a01af783310 100644
> > --- a/tools/perf/util/trace-event-read.c
> > +++ b/tools/perf/util/trace-event-read.c
> > @@ -361,6 +361,7 @@ static int read_saved_cmdline(struct tep_handle *pevent)
> >                 pr_debug("error reading saved cmdlines\n");
> >                 goto out;
> >         }
> > +       buf[ret] = '\0';
> >
> >         parse_saved_cmdline(pevent, buf, size);
> >         ret = 0;
> > --
> > 2.30.1.766.gb4fecdf3b7-goog
> >

-- 

- Arnaldo