linux-kernel - Re: [PATCH] ALSA: hda/realtek: Add quirk for Clevo NH55RZQ

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <s5hsg5dfy4h.wl-tiwai@suse.de>
Date:   Tue, 02 Mar 2021 15:06:54 +0100
From:   Takashi Iwai <tiwai@...e.de>
To:     Werner Sembach <wse@...edocomputers.com>
Cc:     perex@...ex.cz, tiwai@...e.com, alsa-devel@...a-project.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ALSA: hda/realtek: Add quirk for Clevo NH55RZQ

On Tue, 02 Mar 2021 12:19:03 +0100,
Werner Sembach wrote:
> 
> From: Eckhart Mohr <e.mohr@...edocomputers.com>
> 
> ALSA: hda/realtek: Add quirk for Clevo NH55RZQ
> 
> This applies a SND_PCI_QUIRK(...) to the Clevo NH55RZQ barebone. This
> fixes the issue of the device not recognizing a pluged in microphone.
> 
> The device has both, a microphone only jack, and a speaker + microphone
> combo jack. The combo jack already works. The microphone-only jack does
> not recognize when a device is pluged in without this patch.
> 
> Signed-off-by: Eckhart Mohr <e.mohr@...edocomputers.com>
> Co-developed-by: Werner Sembach <wse@...edocomputers.com>
> Signed-off-by: Werner Sembach <wse@...edocomputers.com>
> ---
> Hi,
> this is my first ever submitted kernel patch, feel free to criticise me if I made an error or missed a best practise bullet point.

The patch isn't cleanly applicable.  Could you try to submit via
git-send-email instead?

> Also: I'm unsure if this would fit the requirements for stable@...r.kernel.org and/or trivial@...nel.org, but I think not (correct me if I'm wrong).

Cc to stable is worthwhile.  You can simply add
  Cc: <stable@...r.kernel.org>

around your signed-off-by lines in the patch.


thanks,

Takashi