linux-kernel - Re: [PATCH][next] drm/amd/display: fix the return of the uninitialized value in ret

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b9a11c62-f469-8f5b-9585-74b73cd5a9db@amd.com>
Date:   Tue, 2 Mar 2021 10:03:13 -0500
From:   Harry Wentland <harry.wentland@....com>
To:     Colin King <colin.king@...onical.com>, Leo Li <sunpeng.li@....com>,
        Alex Deucher <alexander.deucher@....com>,
        Christian König <christian.koenig@....com>,
        David Airlie <airlied@...ux.ie>,
        Daniel Vetter <daniel@...ll.ch>,
        Anson Jacob <Anson.Jacob@....com>,
        Mikita Lipski <Mikita.Lipski@....com>,
        amd-gfx@...ts.freedesktop.org, dri-devel@...ts.freedesktop.org
Cc:     kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH][next] drm/amd/display: fix the return of the
 uninitialized value in ret

On 2021-03-02 9:05 a.m., Colin King wrote:
> From: Colin Ian King <colin.king@...onical.com>
> 
> Currently if stream->signal is neither SIGNAL_TYPE_DISPLAY_PORT_MST or
> SIGNAL_TYPE_DISPLAY_PORT then variable ret is uninitialized and this is
> checked for > 0 at the end of the function.  Ret should be initialized,
> I believe setting it to zero is a correct default.
> 
> Addresses-Coverity: ("Uninitialized scalar variable")
> Fixes: bd0c064c161c ("drm/amd/display: Add return code instead of boolean for future use")
> Signed-off-by: Colin Ian King <colin.king@...onical.com>

Reviewed-by: Harry Wentland <harry.wentland@....com>

Harry

> ---
>   drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_helpers.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_helpers.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_helpers.c
> index 5159399f8239..5750818db8f6 100644
> --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_helpers.c
> +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_helpers.c
> @@ -530,7 +530,7 @@ bool dm_helpers_dp_write_dsc_enable(
>   {
>   	uint8_t enable_dsc = enable ? 1 : 0;
>   	struct amdgpu_dm_connector *aconnector;
> -	uint8_t ret;
> +	uint8_t ret = 0;
>   
>   	if (!stream)
>   		return false;
>