linux-kernel - Re: [PATCH v2 2/2] gpio: fix gpio-device list corruption

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CACRpkda7HQf55r7=f2TVvetaV7KavD_Q43CT4P6z97MWM7VjLw@mail.gmail.com>
Date:   Tue, 2 Mar 2021 16:41:21 +0100
From:   Linus Walleij <linus.walleij@...aro.org>
To:     Johan Hovold <johan@...nel.org>
Cc:     Bartosz Golaszewski <bgolaszewski@...libre.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Saravana Kannan <saravanak@...gle.com>,
        "open list:GPIO SUBSYSTEM" <linux-gpio@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        stable <stable@...r.kernel.org>
Subject: Re: [PATCH v2 2/2] gpio: fix gpio-device list corruption

On Mon, Mar 1, 2021 at 10:05 AM Johan Hovold <johan@...nel.org> wrote:

> Make sure to hold the gpio_lock when removing the gpio device from the
> gpio_devices list (when dropping the last reference) to avoid corrupting
> the list when there are concurrent accesses.
>
> Fixes: ff2b13592299 ("gpio: make the gpiochip a real device")
> Cc: stable@...r.kernel.org      # 4.6
> Reviewed-by: Saravana Kannan <saravanak@...gle.com>
> Signed-off-by: Johan Hovold <johan@...nel.org>

Excellent fix as well,
Reviewed-by: Linus Walleij <linus.walleij@...aro.org>

Yours,
Linus Walleij