linux-kernel - Re: [PATCH v3 2/2] leds: lgm: Add LED controller driver for LGM SoC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 2 Mar 2021 16:55:34 +0100
From:   Pavel Machek <pavel@....cz>
To:     Geert Uytterhoeven <geert@...ux-m68k.org>
Cc:     Amireddy Mallikarjuna reddy <mallikarjunax.reddy@...ux.intel.com>,
        linux-leds <linux-leds@...r.kernel.org>,
        Dan Murphy <dmurphy@...com>,
        "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
        <devicetree@...r.kernel.org>, Rob Herring <robh+dt@...nel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        cheol.yong.kim@...el.com, qi-ming.wu@...el.com,
        malliamireddy009@...il.com, yixin.zhu@...el.com
Subject: Re: [PATCH v3 2/2] leds: lgm: Add LED controller driver for LGM SoC

Hi!

> > --- /dev/null
> > +++ b/drivers/leds/blink/Kconfig
> > @@ -0,0 +1,20 @@
> > +menuconfig LEDS_BLINK
> > +       bool "LED Blink support"
> > +       depends on LEDS_CLASS
> > +       help
> > +         This option enables blink support for the leds class.
> > +         If unsure, say Y.
> 
> What is the purpose of the LEDS_BLINK config symbol?
> Blink support for the leds class is always available, regardless of the
> value of this symbol, and controlled for individual drivers by filling
> in the led_classdev.blink_set() callback.

We don't really need the symbol.

> > +if LEDS_BLINK
> > +
> > +config LEDS_BLINK_LGM
> > +       tristate "LED support for Intel LGM SoC series"
> > +       depends on LEDS_CLASS
> > +       depends on MFD_SYSCON
> > +       depends on OF
> > +       help
> > +         Parallel to serial conversion, which is also called SSO controller,
> > +         can drive external shift register for LED outputs.
> > +         This enables LED support for Serial Shift Output controller(SSO).
> 
> What's so special about this driver that it needs a new "blink" subdir?
> Isn't it an ordinary LED driver?
> Looking at the code filling in the .blink_set() callback, the hardware
> blink feature seems to be even optional?

So idea is to start putting drivers into subdirectories, because we
have too many of them at the moment.

simple/blink/flash/rgb, or something like that.

Best regards,
								Pavel
-- 
http://www.livejournal.com/~pavelmachek

Download attachment "signature.asc" of type "application/pgp-signature" (196 bytes)