linux-kernel - Re: [PATCH] soc: renesas: rmobile-sysc: Set OF

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAMuHMdULLDcRFhOQrGXuRxTcMeX5bc3fi-CkSSmrejSP6JUKWA@mail.gmail.com>
Date:   Tue, 2 Mar 2021 17:18:21 +0100
From:   Geert Uytterhoeven <geert@...ux-m68k.org>
To:     Sebastian Reichel <sre@...nel.org>
Cc:     Magnus Damm <magnus.damm@...il.com>,
        Saravana Kannan <saravanak@...gle.com>,
        Linux-Renesas <linux-renesas-soc@...r.kernel.org>,
        Linux ARM <linux-arm-kernel@...ts.infradead.org>,
        Linux PM list <linux-pm@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] soc: renesas: rmobile-sysc: Set OF_POPULATED and absorb
 reset handling

Hi Sebastian,

On Tue, Mar 2, 2021 at 4:44 PM Sebastian Reichel <sre@...nel.org> wrote:
> On Fri, Feb 05, 2021 at 02:33:19PM +0100, Geert Uytterhoeven wrote:
> > Currently, there are two drivers binding to the R-Mobile System
> > Controller (SYSC):
> >   - The rmobile-sysc driver registers PM domains from a core_initcall(),
> >     and does not use a platform driver,
> >   - The rmobile-reset driver registers a reset handler, and does use a
> >     platform driver.
> >
> > As fw_devlink only considers devices, it does not know that the
> > rmobile-sysc driver is ready.  Hence if fw_devlink is enabled, probing
> > of on-chip devices that are part of the SYSC PM domain is deferred until
> > the optional rmobile-reset has been bound, which may happen too late
> > (for e.g. the system timer on SoCs lacking an ARM architectured or
> > global timer), or not at all, leading to complete system boot failures.
> >
> > Fix this by:
> >   1. Setting the OF_POPULATED flag for the SYSC device node after
> >      successful initialization.
> >      This will make of_link_to_phandle() ignore the SYSC device node as
> >      a dependency, making consumer devices probe again.
> >   2. Move reset handling from its own driver into the rmobile-sysc
> >      driver.
> >      This is needed because setting OF_POPULATED prevents the
> >      rmobile-reset driver from binding against the same device.
> >
> > Signed-off-by: Geert Uytterhoeven <geert+renesas@...der.be>
> > ---
> > To be queued in renesas-devel for v5.13.
>
> Acked-by: Sebastian Reichel <sre@...nel.org>

In the meantime, this has method been abandoned, and this patch was
superseded by "[PATCH v2] soc: renesas: rmobile-sysc: Mark fwnode when
PM domain is added"
https://lore.kernel.org/linux-arm-kernel/20210216123958.3180014-1-geert+renesas@glider.be/

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds