linux-kernel - Re: [PATCH] staging: rtl8192e: remove unnecessary break

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20210302162417.GU2087@kadam>
Date:   Tue, 2 Mar 2021 19:24:18 +0300
From:   Dan Carpenter <dan.carpenter@...cle.com>
To:     Perrin Smith <perrinjamessmith@...il.com>
Cc:     gregkh@...uxfoundation.org, devel@...verdev.osuosl.org,
        yashsri421@...il.com, tiwai@...e.de, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: rtl8192e: remove unnecessary break

On Tue, Mar 02, 2021 at 11:29:03PM +0800, Perrin Smith wrote:
> From: Perrin Smith <perrinjamessmith@...il.com>
> 
> removed unnecessary break at end of while loop
> 
> Signed-off-by: Perrin Smith <perrinjamessmith@...il.com>
> ---
>  drivers/staging/rtl8192e/rtllib_rx.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/staging/rtl8192e/rtllib_rx.c b/drivers/staging/rtl8192e/rtllib_rx.c
> index b8ab34250e6a..2de6330b7737 100644
> --- a/drivers/staging/rtl8192e/rtllib_rx.c
> +++ b/drivers/staging/rtl8192e/rtllib_rx.c
> @@ -460,8 +460,6 @@ static bool AddReorderEntry(struct rx_ts_record *pTS,
>  			((struct rx_reorder_entry *)list_entry(pList->next,
>  			struct rx_reorder_entry, List))->SeqNum))
>  			return false;
> -		else
> -			break;

No, this break is necessary.  The patch introduces a bug.  You need to
be careful following checkpatch's advice because it's just a simple
Perl script.

>  	}

regards,
dan carpenter