[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Wed, 3 Mar 2021 18:21:14 +0100
From: Jean-Philippe Brucker <jean-philippe@...aro.org>
To: Vivek Gautam <vivek.gautam@....com>
Cc: linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
iommu@...ts.linux-foundation.org,
virtualization@...ts.linux-foundation.org, joro@...tes.org,
will.deacon@....com, mst@...hat.com, robin.murphy@....com,
eric.auger@...hat.com, alex.williamson@...hat.com,
kevin.tian@...el.com, jacob.jun.pan@...ux.intel.com,
yi.l.liu@...el.com, lorenzo.pieralisi@....com,
shameerali.kolothum.thodi@...wei.com
Subject: Re: [PATCH RFC v1 09/15] iommu/virtio: Update table format probing
header
On Fri, Jan 15, 2021 at 05:43:36PM +0530, Vivek Gautam wrote:
> Add info about asid_bits and additional flags to table format
> probing header.
>
> Signed-off-by: Vivek Gautam <vivek.gautam@....com>
> Cc: Joerg Roedel <joro@...tes.org>
> Cc: Will Deacon <will.deacon@....com>
> Cc: Michael S. Tsirkin <mst@...hat.com>
> Cc: Robin Murphy <robin.murphy@....com>
> Cc: Jean-Philippe Brucker <jean-philippe@...aro.org>
> Cc: Eric Auger <eric.auger@...hat.com>
> Cc: Alex Williamson <alex.williamson@...hat.com>
> Cc: Kevin Tian <kevin.tian@...el.com>
> Cc: Jacob Pan <jacob.jun.pan@...ux.intel.com>
> Cc: Liu Yi L <yi.l.liu@...el.com>
> Cc: Lorenzo Pieralisi <lorenzo.pieralisi@....com>
> Cc: Shameerali Kolothum Thodi <shameerali.kolothum.thodi@...wei.com>
> ---
> include/uapi/linux/virtio_iommu.h | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/include/uapi/linux/virtio_iommu.h b/include/uapi/linux/virtio_iommu.h
> index 43821e33e7af..8a0624bab4b2 100644
> --- a/include/uapi/linux/virtio_iommu.h
> +++ b/include/uapi/linux/virtio_iommu.h
> @@ -169,7 +169,10 @@ struct virtio_iommu_probe_pasid_size {
> struct virtio_iommu_probe_table_format {
> struct virtio_iommu_probe_property head;
> __le16 format;
> - __u8 reserved[2];
> + __le16 asid_bits;
> +
> + __le32 flags;
This struct should only contain the head and format fields. asid and flags
should go in a specialized structure - virtio_iommu_probe_pgt_arm64 in the
latest spec draft, where I dropped the asid_bits field in favor of an
"ASID16" flag.
Thanks,
Jean
Powered by blists - more mailing lists