linux-kernel - Re: [PATCH v1 0/3] driver core: Set fw

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 03 Mar 2021 11:21:05 +0100
From:   Michael Walle <michael@...le.cc>
To:     Saravana Kannan <saravanak@...gle.com>
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        "Rafael J. Wysocki" <rafael@...nel.org>,
        Jon Hunter <jonathanh@...dia.com>,
        Marek Szyprowski <m.szyprowski@...sung.com>,
        Geert Uytterhoeven <geert@...ux-m68k.org>,
        Guenter Roeck <linux@...ck-us.net>,
        Android Kernel Team <kernel-team@...roid.com>,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v1 0/3] driver core: Set fw_devlink=on take II

Am 2021-03-03 10:28, schrieb Saravana Kannan:
> On Wed, Mar 3, 2021 at 12:59 AM Michael Walle <michael@...le.cc> wrote:
>> 
>> Am 2021-03-02 23:47, schrieb Saravana Kannan:
>> > On Tue, Mar 2, 2021 at 2:42 PM Saravana Kannan <saravanak@...gle.com>
>> > wrote:
>> >>
>> >> On Tue, Mar 2, 2021 at 2:24 PM Michael Walle <michael@...le.cc> wrote:
>> >> >
>> >> > Am 2021-03-02 22:11, schrieb Saravana Kannan:
>> >> > > I think Patch 1 should fix [4] without [5]. Can you test the series
>> >> > > please?
>> >> >
>> >> > Mh, I'm on latest linux-next (next-20210302) and I've applied patch 3/3
>> >> > and
>> >> > reverted commit 7007b745a508 ("PCI: layerscape: Convert to
>> >> > builtin_platform_driver()"). I'd assumed that PCIe shouldn't be working,
>> >> > right? But it is. Did I miss something?
>> >>
>> >> You need to revert [5].
>> >
>> > My bad. You did revert it. Ah... I wonder if it was due to
>> > fw_devlink.strict that I added. To break PCI again, also set
>> > fw_devlink.strict=1 in the kernel command line.
>> 
>> Indeed, adding fw_devlink.strict=1 will break PCI again. But if
>> I then apply 1/3 and 2/3 again, PCI is still broken. Just to be clear:
>> I'm keeping the fw_devlink.strict=1 parameter.
> 
> Thanks for your testing! I assume you are also setting fw_devlink=on?

I've applied patch 3/3 and added nothing to the commandline, so yes.

> Hmmm... ok. In the working case, does your PCI probe before IOMMU? If
> yes, then your results make sense.

Yes that was the conclusion last time. That the probe is deferred and
the __init section is already discarded when there might a second
try of the probe.

So I guess, Patch 1/3 and Patch 2/3 doesn't fix that and the drivers
still need to be converted to builtin_platform_driver(), right?

> If your PCI does probe after IOMMU and uses IOMMU, then I'm not sure
> what else could be changing the order of the device probing. In any
> case, glad that the default case works and we have a fix merged even
> for .strict=1.
> 
> -Saravana

-michael