[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Wed, 3 Mar 2021 10:29:36 +0100
From: Christoph Hellwig <hch@....de>
To: Shiyang Ruan <ruansy.fnst@...itsu.com>
Cc: linux-kernel@...r.kernel.org, linux-xfs@...r.kernel.org,
linux-nvdimm@...ts.01.org, linux-fsdevel@...r.kernel.org,
darrick.wong@...cle.com, dan.j.williams@...el.com,
willy@...radead.org, jack@...e.cz, viro@...iv.linux.org.uk,
linux-btrfs@...r.kernel.org, ocfs2-devel@....oracle.com,
david@...morbit.com, hch@....de, rgoldwyn@...e.de
Subject: Re: [PATCH v2 04/10] fsdax: Introduce dax_iomap_cow_copy()
On Fri, Feb 26, 2021 at 08:20:24AM +0800, Shiyang Ruan wrote:
> + if (!copy_edge) {
> + ret = copy_mc_to_kernel(daddr, saddr, length);
> + return ret;
No need for the ret variable here, this can be:
if (!copy_edge)
return copy_mc_to_kernel(daddr, saddr, length);
Otherwise looks good:
Reviewed-by: Christoph Hellwig <hch@....de>
Powered by blists - more mailing lists