linux-kernel - Re: [RESEND 1/1] arch: arm: mach-at91: pm: Move prototypes to mutually included header

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 3 Mar 2021 14:14:57 +0000
From:   Lee Jones <lee.jones@...aro.org>
To:     Alexandre Belloni <alexandre.belloni@...tlin.com>
Cc:     linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
        Russell King <linux@...linux.org.uk>,
        Nicolas Ferre <nicolas.ferre@...rochip.com>,
        Ludovic Desroches <ludovic.desroches@...rochip.com>
Subject: Re: [RESEND 1/1] arch: arm: mach-at91: pm: Move prototypes to
 mutually included header

On Wed, 03 Mar 2021, Alexandre Belloni wrote:

> On 03/03/2021 12:41:49+0000, Lee Jones wrote:
> > Both the caller and the supplier's source file should have access to
> > the include file containing the prototypes.
> > 
> > Fixes the following W=1 kernel build warning(s):
> > 
> >  drivers/pinctrl/pinctrl-at91.c:1637:6: warning: no previous prototype for ‘at91_pinctrl_gpio_suspend’ [-Wmissing-prototypes]
> >  1637 | void at91_pinctrl_gpio_suspend(void)
> >  | ^~~~~~~~~~~~~~~~~~~~~~~~~
> >  drivers/pinctrl/pinctrl-at91.c:1661:6: warning: no previous prototype for ‘at91_pinctrl_gpio_resume’ [-Wmissing-prototypes]
> >  1661 | void at91_pinctrl_gpio_resume(void)
> >  | ^~~~~~~~~~~~~~~~~~~~~~~~
> > 
> > Cc: Russell King <linux@...linux.org.uk>
> > Cc: Nicolas Ferre <nicolas.ferre@...rochip.com>
> > Cc: Alexandre Belloni <alexandre.belloni@...tlin.com>
> > Cc: Ludovic Desroches <ludovic.desroches@...rochip.com>
> > Signed-off-by: Lee Jones <lee.jones@...aro.org>
> 
> I'm pretty sure you had my ack on v3 ;)
> 
> Acked-by: Alexandre Belloni <alexandre.belloni@...tlin.com>
> 
> or again, alternatively, I can apply it with Linus' ack

That would be my preference, thanks.

> > ---
> >  arch/arm/mach-at91/pm.c        | 19 ++++++++-----------
> >  drivers/pinctrl/pinctrl-at91.c |  2 ++
> >  include/soc/at91/pm.h          | 16 ++++++++++++++++
> >  3 files changed, 26 insertions(+), 11 deletions(-)
> >  create mode 100644 include/soc/at91/pm.h

-- 
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog