linux-kernel - Re: [PATCH 7/7] media: uapi: move VP8 stateless controls out of staging

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 3 Mar 2021 15:29:48 +0100
From:   Hans Verkuil <hverkuil@...all.nl>
To:     Ezequiel Garcia <ezequiel@...labora.com>,
        linux-media@...r.kernel.org, linux-kernel@...r.kernel.org
Cc:     Nicolas Dufresne <nicolas.dufresne@...labora.com>,
        Alexandre Courbot <acourbot@...omium.org>, kernel@...labora.com
Subject: Re: [PATCH 7/7] media: uapi: move VP8 stateless controls out of
 staging

Hi Ezequiel,

This series looks very good. There is just one define that needs a V4L2_ prefix:

On 02/03/2021 21:54, Ezequiel Garcia wrote:
> Until now, the VP8 V4L2 API was not exported as a public API,
> and only defined in a private media header (media/vp8-ctrls.h).
> 
> The reason for this was a concern about the API not complete
> and ready to support VP8 decoding hardware accelerators.
> 
> After reviewing the VP8 specification in detail, and now
> that the API is able to support Cedrus and Hantro G1,
> we can consider this ready.
> 
> Signed-off-by: Ezequiel Garcia <ezequiel@...labora.com>

<snip>

> diff --git a/include/uapi/linux/v4l2-controls.h b/include/uapi/linux/v4l2-controls.h

<snip>

> +#define VP8_FRAME_IS_KEY_FRAME(hdr) \
> +	(!!((hdr)->flags & V4L2_VP8_FRAME_FLAG_KEY_FRAME))

It's used in several drivers, so it is probably best to add a separate
patch before this patch to rename it.

Everything else looks fine, so I expect to make a PR once I have a v2 that
fixes this.

Regards,

	Hans