linux-kernel - Re: [PATCH v2] workqueue: Move the position of debug_work_activate() in __queue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 3 Mar 2021 10:14:50 -0500
From:   Tejun Heo <tj@...nel.org>
To:     qiang.zhang@...driver.com
Cc:     jiangshanlai@...il.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] workqueue: Move the position of debug_work_activate()
 in __queue_work()

On Thu, Feb 18, 2021 at 11:16:49AM +0800, qiang.zhang@...driver.com wrote:
> From: Zqiang <qiang.zhang@...driver.com>
> 
> The debug_work_activate() is called on the premise that
> the work can be inserted, because if wq be in WQ_DRAINING
> status, insert work may be failed.
> 
> Fixes: e41e704bc4f4 ("workqueue: improve destroy_workqueue() debuggability")
> Signed-off-by: Zqiang <qiang.zhang@...driver.com>
> Reviewed-by: Lai Jiangshan <jiangshanlai@...il.com>

Applied to wq/for-5.12-fixes.

Thanks.

-- 
tejun