linux-kernel - Re: [PATCH v2 06/12] lib: bitmap: order includes alphabetically

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YEDZsMeyDgwU/O8X@smile.fi.intel.com>
Date:   Thu, 4 Mar 2021 14:59:28 +0200
From:   Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To:     Bartosz Golaszewski <brgl@...ev.pl>
Cc:     Joel Becker <jlbec@...lplan.org>, Christoph Hellwig <hch@....de>,
        Shuah Khan <shuah@...nel.org>,
        Linus Walleij <linus.walleij@...aro.org>,
        Uwe Kleine-König 
        <u.kleine-koenig@...gutronix.de>,
        Geert Uytterhoeven <geert@...ux-m68k.org>,
        Kent Gibson <warthog618@...il.com>,
        Jonathan Corbet <corbet@....net>, linux-gpio@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-doc@...r.kernel.org,
        Bartosz Golaszewski <bgolaszewski@...libre.com>
Subject: Re: [PATCH v2 06/12] lib: bitmap: order includes alphabetically

On Thu, Mar 04, 2021 at 11:24:46AM +0100, Bartosz Golaszewski wrote:
> From: Bartosz Golaszewski <bgolaszewski@...libre.com>
> 
> For better readability and maintenance: order the includes in bitmap
> source files alphabetically.

Reviewed-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>

> Signed-off-by: Bartosz Golaszewski <bgolaszewski@...libre.com>
> ---
>  include/linux/bitmap.h | 4 ++--
>  lib/bitmap.c           | 9 +++++----
>  2 files changed, 7 insertions(+), 6 deletions(-)
> 
> diff --git a/include/linux/bitmap.h b/include/linux/bitmap.h
> index 6939a8983026..3282db97e06c 100644
> --- a/include/linux/bitmap.h
> +++ b/include/linux/bitmap.h
> @@ -4,10 +4,10 @@
>  
>  #ifndef __ASSEMBLY__
>  
> -#include <linux/types.h>
>  #include <linux/bitops.h>
> -#include <linux/string.h>
>  #include <linux/kernel.h>
> +#include <linux/string.h>
> +#include <linux/types.h>
>  
>  /*
>   * bitmaps provide bit arrays that consume one or more unsigned
> diff --git a/lib/bitmap.c b/lib/bitmap.c
> index 75006c4036e9..78f70d9007ad 100644
> --- a/lib/bitmap.c
> +++ b/lib/bitmap.c
> @@ -3,17 +3,18 @@
>   * lib/bitmap.c
>   * Helper functions for bitmap.h.
>   */
> -#include <linux/export.h>
> -#include <linux/thread_info.h>
> -#include <linux/ctype.h>
> -#include <linux/errno.h>
> +
>  #include <linux/bitmap.h>
>  #include <linux/bitops.h>
>  #include <linux/bug.h>
> +#include <linux/ctype.h>
> +#include <linux/errno.h>
> +#include <linux/export.h>
>  #include <linux/kernel.h>
>  #include <linux/mm.h>
>  #include <linux/slab.h>
>  #include <linux/string.h>
> +#include <linux/thread_info.h>
>  #include <linux/uaccess.h>
>  
>  #include <asm/page.h>
> -- 
> 2.29.1
> 

-- 
With Best Regards,
Andy Shevchenko