linux-kernel - Re: [PATCH v5 1/7] pwm: pca9685: Switch to atomic API

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YEDcpAtQAc2Mu6Wz@workstation.tuxnet>
Date:   Thu, 4 Mar 2021 14:12:04 +0100
From:   Clemens Gruber <clemens.gruber@...ruber.com>
To:     Uwe Kleine-König 
        <u.kleine-koenig@...gutronix.de>
Cc:     linux-pwm@...r.kernel.org,
        Thierry Reding <thierry.reding@...il.com>,
        Sven Van Asbroeck <TheSven73@...il.com>,
        Lee Jones <lee.jones@...aro.org>, linux-kernel@...r.kernel.org,
        Mika Westerberg <mika.westerberg@...ux.intel.com>,
        David Jander <david@...tonic.nl>
Subject: Re: [PATCH v5 1/7] pwm: pca9685: Switch to atomic API

Hi Uwe,

On Mon, Mar 01, 2021 at 10:44:07PM +0100, Uwe Kleine-König wrote:
> Hello Clemens,
> 
> On Tue, Dec 15, 2020 at 10:22:22PM +0100, Clemens Gruber wrote:
> > +	if (state->polarity != PWM_POLARITY_NORMAL)
> > +		return -EOPNOTSUPP;
> 
> We agreed on -EINVAL for that one since 2b1c1a5d5148.
> 
> Other than that the patch looks ok (but note I only looked quickly).

Thanks for looking over it. This will be -EINVAL in the next revision.

Best regards,
Clemens