linux-kernel - Re: [PATCH] platform/x86: Switch to using the new API kobj_to

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <39606d42-f60e-0c17-4c70-4e94eafbb1a0@redhat.com>
Date:   Thu, 4 Mar 2021 14:33:10 +0100
From:   Hans de Goede <hdegoede@...hat.com>
To:     Yang Li <yang.lee@...ux.alibaba.com>, ike.pan@...onical.com
Cc:     mgross@...ux.intel.com, platform-driver-x86@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] platform/x86: Switch to using the new API kobj_to_dev()

Hi,

On 2/22/21 8:00 AM, Yang Li wrote:
> fixed the following coccicheck:
> ./drivers/platform/x86/ideapad-laptop.c:523:60-61: WARNING opportunity
> for kobj_to_dev()
> 
> Reported-by: Abaci Robot <abaci@...ux.alibaba.com>
> Signed-off-by: Yang Li <yang.lee@...ux.alibaba.com>

Patch does not apply, please resend it rebased on the latest pdx86/for-next branch:

https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/log/?h=for-next

Regards,

Hans

> ---
>  drivers/platform/x86/ideapad-laptop.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/platform/x86/ideapad-laptop.c b/drivers/platform/x86/ideapad-laptop.c
> index 5b81baf..d6ca4f0 100644
> --- a/drivers/platform/x86/ideapad-laptop.c
> +++ b/drivers/platform/x86/ideapad-laptop.c
> @@ -520,7 +520,7 @@ static umode_t ideapad_is_visible(struct kobject *kobj,
>  				 struct attribute *attr,
>  				 int idx)
>  {
> -	struct device *dev = container_of(kobj, struct device, kobj);
> +	struct device *dev = kobj_to_dev(kobj);
>  	struct ideapad_private *priv = dev_get_drvdata(dev);
>  	bool supported;
>  
>