linux-kernel - Re: [PATCH v9 6/9] crypto: Add NIST P384 curve parameters

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <37e5c232-11e8-0533-ab3e-676829091d19@linux.ibm.com>
Date:   Thu, 4 Mar 2021 08:59:36 -0500
From:   Stefan Berger <stefanb@...ux.ibm.com>
To:     Herbert Xu <herbert@...dor.apana.org.au>,
        Stefan Berger <stefanb@...ux.vnet.ibm.com>
Cc:     keyrings@...r.kernel.org, linux-crypto@...r.kernel.org,
        davem@...emloft.net, dhowells@...hat.com, zohar@...ux.ibm.com,
        linux-kernel@...r.kernel.org, patrick@...terwijk.org,
        linux-integrity@...r.kernel.org,
        Saulo Alessandre <saulo.alessandre@....jus.br>
Subject: Re: [PATCH v9 6/9] crypto: Add NIST P384 curve parameters

On 3/4/21 12:28 AM, Herbert Xu wrote:
> On Thu, Feb 25, 2021 at 11:07:59AM -0500, Stefan Berger wrote:
>> From: Saulo Alessandre <saulo.alessandre@....jus.br>
>>
>> * crypto/ecc_curve_defs.h
>>    - add nist_p384 params
>>
>> * include/crypto/ecdh.h
>>    - add ECC_CURVE_NIST_P384
>>
>> Signed-off-by: Saulo Alessandre <saulo.alessandre@....jus.br>
>> Tested-by: Stefan Berger <stefanb@...ux.ibm.com>
>> ---
>>   crypto/ecc_curve_defs.h | 32 ++++++++++++++++++++++++++++++++
>>   include/crypto/ecdh.h   |  1 +
>>   2 files changed, 33 insertions(+)
> Can you reorder the patches so that the crypto patches come first
> and then I can apply them?

Yes, sounds good.

Are you going to take the other patches as well, except for maybe 9/9, 
which depends on Nayan's patch series. Mimi suggested to me to ask you 
whether you could create a topic branch where we can apply other patches 
to, such as Nayna's?

The NIST P384 patch temporarily introduces this warning, which goes away 
when the immediately following patch (current 7/9) is applied. Is this 
an issue or should I squash Saulo's patches or put the top hunk from 7/9 
into 6/9?


In file included from crypto/ecc.c:38:
crypto/ecc_curve_defs.h:76:25: warning: ?nist_p384? defined but not used 
[-Wunused-variable]
    76 | static struct ecc_curve nist_p384 = {
       |                         ^~~~~~~~~

    Stefan


>
> Thanks,