linux-kernel - Re: [PATCH mm] kfence: fix reports if constant function prefixes exist

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CANpmjNPk0GYuiz1YZddJ1GjZuUXUrXFVZujoaH0UKDknpc-vgQ@mail.gmail.com>
Date:   Thu, 4 Mar 2021 15:43:50 +0100
From:   Marco Elver <elver@...gle.com>
To:     Marco Elver <elver@...gle.com>,
        Andrew Morton <akpm@...ux-foundation.org>
Cc:     Alexander Potapenko <glider@...gle.com>,
        Dmitry Vyukov <dvyukov@...gle.com>,
        Andrey Konovalov <andreyknvl@...gle.com>,
        Jann Horn <jannh@...gle.com>,
        LKML <linux-kernel@...r.kernel.org>,
        Linux Memory Management List <linux-mm@...ck.org>,
        kasan-dev <kasan-dev@...glegroups.com>,
        Christophe Leroy <christophe.leroy@...roup.eu>
Subject: Re: [PATCH mm] kfence: fix reports if constant function prefixes exist

On Thu, 4 Mar 2021 at 15:40, Marco Elver <elver@...gle.com> wrote:
> Some architectures prefix all functions with a constant string ('.' on
> ppc64). Add ARCH_FUNC_PREFIX, which may optionally be defined in
> <asm/kfence.h>, so that get_stack_skipnr() can work properly.
>
> Link: https://lkml.kernel.org/r/f036c53d-7e81-763c-47f4-6024c6c5f058@csgroup.eu
> Reported-by: Christophe Leroy <christophe.leroy@...roup.eu>
> Tested-by: Christophe Leroy <christophe.leroy@...roup.eu>
> Signed-off-by: Marco Elver <elver@...gle.com>
> ---

For further context, the corresponding ppc64-enablement patch is was
just sent by Christophe:

  https://lkml.kernel.org/r/afaec81a551ef15345cb7d7563b3fac3d7041c3a.1614868445.git.christophe.leroy@csgroup.eu

But there is no strict dependency between the patches, only that the
stack traces that KFENCE prints aren't as pretty without the
ARCH_FUNC_PREFIX patch.

So it should be fine to take them through different trees, as long as
they both make the next merge window.

Thanks,
-- Marco