linux-kernel - Re: [PATCH v2] gpio: regmap: set gpio_chip of

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHp75Vc6azROSAc=ZUjY+VhAjZDMsukr2ZY1fQHMFwncL7_AbQ@mail.gmail.com>
Date:   Thu, 4 Mar 2021 17:22:13 +0200
From:   Andy Shevchenko <andy.shevchenko@...il.com>
To:     Álvaro Fernández Rojas <noltari@...il.com>
Cc:     Michael Walle <michael@...le.cc>,
        Linus Walleij <linus.walleij@...aro.org>,
        Bartosz Golaszewski <bgolaszewski@...libre.com>,
        "open list:GPIO SUBSYSTEM" <linux-gpio@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2] gpio: regmap: set gpio_chip of_node

On Thu, Mar 4, 2021 at 5:18 PM Álvaro Fernández Rojas <noltari@...il.com> wrote:
>
> This is needed for properly registering gpio regmap as a child of a regmap
> pin controller.

> +       chip->of_node = config->of_node ?: dev_of_node(config->parent);

After a closer look I have no clue why you need this patch at all.
The second part, i.e. assigning parent's fwnode, is done already in
the GPIO library core.
The first part, keeping fwnode in the regmap configuration puzzles me. Why?

-- 
With Best Regards,
Andy Shevchenko