lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <CAHp75Vf6+1u5myV7cL1903Qc92H7vPFMuc916-_wjKQ6zwmoqg@mail.gmail.com> Date: Thu, 4 Mar 2021 17:25:35 +0200 From: Andy Shevchenko <andy.shevchenko@...il.com> To: Álvaro Fernández Rojas <noltari@...il.com> Cc: Linus Walleij <linus.walleij@...aro.org>, Rob Herring <robh+dt@...nel.org>, Michael Walle <michael@...le.cc>, Bartosz Golaszewski <bgolaszewski@...libre.com>, Florian Fainelli <f.fainelli@...il.com>, bcm-kernel-feedback-list <bcm-kernel-feedback-list@...adcom.com>, Jonas Gorski <jonas.gorski@...il.com>, Necip Fazil Yildiran <fazilyildiran@...il.com>, "open list:GPIO SUBSYSTEM" <linux-gpio@...r.kernel.org>, devicetree <devicetree@...r.kernel.org>, Linux Kernel Mailing List <linux-kernel@...r.kernel.org>, linux-arm Mailing List <linux-arm-kernel@...ts.infradead.org> Subject: Re: [PATCH v4 05/15] pinctrl: add a pincontrol driver for BCM6328 On Thu, Mar 4, 2021 at 2:25 PM Álvaro Fernández Rojas <noltari@...il.com> wrote: > > El 4 mar 2021, a las 13:12, Andy Shevchenko <andy.shevchenko@...il.com> escribió: > > On Thu, Mar 4, 2021 at 1:13 PM Álvaro Fernández Rojas <noltari@...il.com> wrote: > >>> El 4 mar 2021, a las 11:49, Andy Shevchenko <andy.shevchenko@...il.com> escribió: > >>> On Thu, Mar 4, 2021 at 10:57 AM Álvaro Fernández Rojas > >>> <noltari@...il.com> wrote: ... > >>>> + BCM6328_MUX_LO_REG, > >>>> + BCM6328_MUX_HI_REG, > >>> > >>>> + BCM6328_MUX_OTHER_REG > >>> > >>> When it's not terminator add a comma, otherwise remove a comma. > > > >> … so you want me to add a comma or not? > > > > Hmm... you tell me! If this is a list which covers all possible cases > > _and_ the last one is the kinda maximum value (aka terminator), then > > comma is not needed, otherwise add it (to me feels like the latter > > should be done here). > > Well… Then it shouldn’t be needed, since this is a list which covers all possible cases and the last one is a terminator. Honestly the name suggests otherwise. And looking into the code there is no guarantee you won't split that _OTHER_ area to something with new compatible hardware. Renaming to BCM6328_MUX_MAX_REG will clear that this is terminator, but it means its value shouldn't be used except as to understand the amount of supported registers of this enumerator. -- With Best Regards, Andy Shevchenko
Powered by blists - more mailing lists