linux-kernel - Re: [PATCH v3] mm: cma: support sysfs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <YED/NlZJ9QmMss4I@google.com>
Date:   Thu, 4 Mar 2021 07:39:34 -0800
From:   Minchan Kim <minchan@...nel.org>
To:     Andrew Morton <akpm@...ux-foundation.org>
Cc:     linux-mm <linux-mm@...ck.org>, LKML <linux-kernel@...r.kernel.org>,
        joaodias@...gle.com, willy@...radead.org, surenb@...gle.com,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        John Hubbard <jhubbard@...dia.com>
Subject: Re: [PATCH v3] mm: cma: support sysfs

On Wed, Mar 03, 2021 at 10:09:57PM -0800, Andrew Morton wrote:
> On Wed, 3 Mar 2021 17:38:12 -0800 Minchan Kim <minchan@...nel.org> wrote:
> 
> > > >  #endif
> > > >  	char name[CMA_MAX_NAME];
> > > > +#ifdef CONFIG_CMA_SYSFS
> > > > +	struct cma_stat	*stat;
> > > > +#endif
> > > >  };
> > > 
> > > Why aren't the stat fields simply placed directly into struct cma_stat?
> > 
> > It have a related long discussion.
> > https://lore.kernel.org/linux-mm/YCIoHBGELFWAyfMi@kroah.com/
> > https://lore.kernel.org/linux-mm/YCLLKDEQ4NYqb5Y5@kroah.com/
> > 
> > TLDR - Greg really want to see kobject stuff working as dynamic
> > property.
> 
> Please add to changelog?

Sure.

> 
> > > 
> > > ?
> > > 
> > > > +	if (!cma_stats) {
> > > > +		pr_err("failed to create cma_stats\n");
> > > 
> > > Probably unneeded - the ENOMEM stack backtrace will point straight here.
> > 
> > I failed to find the point you mentioned to print backtrace.
> > Where code do you mean to dump the backtrace?
> 
> The thing which __GFP_NOWARN disables.

Got the point.