linux-kernel - Re: [PATCH] MIPS: boot/compressed: Copy DTB to aligned address

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <KKVEPQ.TT4PXOZ85QWA1@crapouillou.net>
Date:   Wed, 03 Mar 2021 20:57:56 +0000
From:   Paul Cercueil <paul@...pouillou.net>
To:     Rob Herring <robh@...nel.org>
Cc:     Thomas Bogendoerfer <tsbogend@...ha.franken.de>, od@...c.me,
        MIPS <linux-mips@...r.kernel.org>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] MIPS: boot/compressed: Copy DTB to aligned address

Hi Rob,

Le mer. 3 mars 2021 à 14:37, Rob Herring <robh@...nel.org> a écrit :
> On Wed, Mar 3, 2021 at 1:33 PM Paul Cercueil <paul@...pouillou.net> 
> wrote:
>> 
>>  Since 5.12-rc1, the Device Tree blob must now be properly aligned.
> 
> I had checked the other built-in cases as microblaze broke too, but
> missed some of the many ways MIPS can have a dtb. Appended and
> built-in DTBs were supposed to be temporary. :(

Actually I'm glad these options are here, they make debugging much 
easier, when working on new SoCs.

-Paul

>>  Therefore, the decompress routine must be careful to copy the blob 
>> at
>>  the next aligned address after the kernel image.
>> 
>>  This commit fixes the kernel sometimes not booting with a Device 
>> Tree
>>  blob appended to it.
>> 
>>  Fixes: c4d5e638d6e9 ("scripts/dtc: Update to upstream version 
>> v1.6.0-51-g183df9e9c2b9")
>>  Signed-off-by: Paul Cercueil <paul@...pouillou.net>
>>  ---
>>   arch/mips/boot/compressed/decompress.c | 8 ++++++++
>>   arch/mips/kernel/vmlinux.lds.S         | 2 ++
>>   2 files changed, 10 insertions(+)
> 
> Acked-by: Rob Herring <robh@...nel.org>