linux-kernel - Re: regression with TTY changes in v5.12-rc1

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <YEEIzO7BrsAwM1LG@kroah.com>
Date:   Thu, 4 Mar 2021 17:20:28 +0100
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     Pierre-Louis Bossart <pierre-louis.bossart@...ux.intel.com>
Cc:     linux-kernel@...r.kernel.org, Jiri Slaby <jirislaby@...nel.org>,
        Corey Minyard <cminyard@...sta.com>,
        Mark Brown <broonie@...nel.org>, Takashi Iwai <tiwai@...e.de>
Subject: Re: regression with TTY changes in v5.12-rc1

On Thu, Mar 04, 2021 at 08:37:44AM -0600, Pierre-Louis Bossart wrote:
> Hi,
> Our SOF/audio CI shows an across-the-board regression when we try v5.12-rc1,
> specifically on pause/resume tests with an interactive terminal running
> 'aplay -i' commands managed by expect to simulate the user pressing the
> space bar to pause/unpause. It turns out the processes are not longer killed
> and the audio devices remain busy (see publicly available test results
> listed below).
> 
> git bisect points to commit 33d4ae9885987 ("drivers:tty:pty: Fix a race
> causing data loss on close"). Reverting the patch fixes the issue on all
> test devices.
> 
> Further analysis with Corey Minyard points to a problem where a slave tty
> will not get a SIGHUP when the master is closed.
> 
> Unless there is an alternate fix, a revert looks necessary?
> 
> Regards
> -Pierre
> 
> https://github.com/thesofproject/linux/pull/2772
> https://sof-ci.01.org/linuxpr/PR2772/build5352/devicetest/

Now reverted.

thanks,

greg k-h