linux-kernel - RE: [bisected] 5.12-rc1 hpsa regression: "scsi: hpsa: Correct dev cmds outstanding for retried cmds" breaks hpsa P600

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 4 Mar 2021 17:00:56 +0000
From:   <Don.Brace@...rochip.com>
To:     <slyich@...il.com>
CC:     <glaubitz@...sik.fu-berlin.de>, <storagedev@...rochip.com>,
        <linux-scsi@...r.kernel.org>, <linux-ia64@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>, <jszczype@...hat.com>,
        <Scott.Benesh@...rochip.com>, <Scott.Teel@...rochip.com>,
        <thenzl@...hat.com>, <martin.petersen@...cle.com>
Subject: RE: [bisected] 5.12-rc1 hpsa regression: "scsi: hpsa: Correct dev
 cmds outstanding for retried cmds" breaks hpsa P600

-----Original Message-----
From: Sergei Trofimovich [mailto:slyich@...il.com] 
Sent: Wednesday, March 3, 2021 4:04 PM
To: Don Brace - C33706 <Don.Brace@...rochip.com>
Cc: glaubitz@...sik.fu-berlin.de; storagedev <storagedev@...rochip.com>; linux-scsi@...r.kernel.org; linux-ia64@...r.kernel.org; linux-kernel@...r.kernel.org; jszczype@...hat.com; Scott Benesh - C33703 <Scott.Benesh@...rochip.com>; Scott Teel - C33730 <Scott.Teel@...rochip.com>; thenzl@...hat.com; martin.petersen@...cle.com
Subject: Re: [bisected] 5.12-rc1 hpsa regression: "scsi: hpsa: Correct dev cmds outstanding for retried cmds" breaks hpsa P600

Glad to hear the patch works. 
The P600 is an unsupported controller that was removed some time ago (by us) and re-added in this patch:
commit 135ae6edeb51979d0998daf1357f149a7d6ebb08 scsi: hpsa: add support for legacy boards
Author: Hannes Reinecke <hare@...e.de>
Date:   Tue Aug 15 08:58:04 2017 +0200

So, when testing the original patch, I no longer have a P600 to test with. It used to be supported by our obsoleted cciss driver.

Since patch f749d8b7a9896bc6e5ffe104cc64345037e0b152 scsi: hpsa: Correct dev cmds outstanding for retried cmds has
already been applied to Martin Petersons 5.13/scsi-queue, perhaps it would be better to send up another patch to correct your alignment issue on these legacy boards.

Wondering what others think about this?

Thanks,
Don