linux-kernel - Re: [PATCH] kprobes: stacktrace: Recover the address changed by kretprobe

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 5 Mar 2021 01:37:58 +0800
From:   kernel test robot <lkp@...el.com>
To:     Masami Hiramatsu <mhiramat@...nel.org>,
        Steven Rostedt <rostedt@...dmis.org>
Cc:     clang-built-linux@...glegroups.com, Daniel Xu <dxu@...uu.xyz>,
        linux-kernel@...r.kernel.org,
        "bpf@...r.kernel.org" <bpf@...r.kernel.org>, kuba@...nel.org
Subject: Re: [PATCH] kprobes: stacktrace: Recover the address changed by
 kretprobe

Hi Masami,

I love your patch! Yet something to improve:

[auto build test ERROR on linus/master]
[also build test ERROR on v5.12-rc1 next-20210304]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Masami-Hiramatsu/kprobes-stacktrace-Recover-the-address-changed-by-kretprobe/20210304-212528
base:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git f69d02e37a85645aa90d18cacfff36dba370f797
config: arm64-randconfig-r023-20210304 (attached as .config)
compiler: clang version 13.0.0 (https://github.com/llvm/llvm-project eec7f8f7b1226be422a76542cb403d02538f453a)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # install arm64 cross compiling tool for clang build
        # apt-get install binutils-aarch64-linux-gnu
        # https://github.com/0day-ci/linux/commit/2204ff150821a6a3c13b4fa10784b5efb3e3adc8
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Masami-Hiramatsu/kprobes-stacktrace-Recover-the-address-changed-by-kretprobe/20210304-212528
        git checkout 2204ff150821a6a3c13b4fa10784b5efb3e3adc8
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=arm64 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>

All errors (new ones prefixed by >>):

>> kernel/stacktrace.c:97:9: error: implicit declaration of function 'kretprobe_real_stack_tsk' [-Werror,-Wimplicit-function-declaration]
           addr = kretprobe_real_stack_tsk(c->tsk, addr, &c->cur);
                  ^
>> kernel/stacktrace.c:97:37: error: no member named 'tsk' in 'struct stacktrace_cookie'
           addr = kretprobe_real_stack_tsk(c->tsk, addr, &c->cur);
                                           ~  ^
>> kernel/stacktrace.c:97:52: error: no member named 'cur' in 'struct stacktrace_cookie'
           addr = kretprobe_real_stack_tsk(c->tsk, addr, &c->cur);
                                                          ~  ^
   3 errors generated.


vim +/kretprobe_real_stack_tsk +97 kernel/stacktrace.c

    85	
    86	static bool stack_trace_consume_entry(void *cookie, unsigned long addr)
    87	{
    88		struct stacktrace_cookie *c = cookie;
    89	
    90		if (c->len >= c->size)
    91			return false;
    92	
    93		if (c->skip > 0) {
    94			c->skip--;
    95			return true;
    96		}
  > 97		addr = kretprobe_real_stack_tsk(c->tsk, addr, &c->cur);
    98		c->store[c->len++] = addr;
    99		return c->len < c->size;
   100	}
   101	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

Download attachment ".config.gz" of type "application/gzip" (33474 bytes)