linux-kernel - Re: [PATCH v5 1/2] dt-bindings: rng: bcm2835: document reset support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <1614890849.112497.2778958.nullmailer@robh.at.kernel.org>
Date:   Thu, 04 Mar 2021 14:47:29 -0600
From:   Rob Herring <robh@...nel.org>
To:     Álvaro Fernández Rojas <noltari@...il.com>
Cc:     linux-kernel@...r.kernel.org,
        Rikard Falkeborn <rikard.falkeborn@...il.com>,
        Scott Branden <sbranden@...adcom.com>,
        bcm-kernel-feedback-list@...adcom.com, Ray Jui <rjui@...adcom.com>,
        Rob Herring <robh+dt@...nel.org>,
        Alexandru Ardelean <alexandru.ardelean@...log.com>,
        Neil Armstrong <narmstrong@...libre.com>,
        devicetree@...r.kernel.org,
        Bjorn Andersson <bjorn.andersson@...aro.org>,
        Nicolas Saenz Julienne <nsaenzjulienne@...e.de>,
        linux-rpi-kernel@...ts.infradead.org,
        Philipp Zabel <p.zabel@...gutronix.de>,
        Matt Mackall <mpm@...enic.com>,
        Guenter Roeck <linux@...ck-us.net>,
        Stefan Wahren <stefan.wahren@...e.com>,
        linux-crypto@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        Herbert Xu <herbert@...dor.apana.org.au>,
        Florian Fainelli <f.fainelli@...il.com>
Subject: Re: [PATCH v5 1/2] dt-bindings: rng: bcm2835: document reset support

On Thu, 04 Mar 2021 08:33:07 +0100, Álvaro Fernández Rojas wrote:
> Some devices may need to perform a reset before using the RNG, such as the
> BCM6368.
> 
> Signed-off-by: Álvaro Fernández Rojas <noltari@...il.com>
> ---
>  v5: no changes.
>  v4: pass dt_binding_check.
>  v3: make resets required if brcm,bcm6368-rng.
>  v2: document reset support.
> 
>  .../devicetree/bindings/rng/brcm,bcm2835.yaml   | 17 +++++++++++++++++
>  1 file changed, 17 insertions(+)
> 

My bot found errors running 'make dt_binding_check' on your patch:

yamllint warnings/errors:

dtschema/dtc warnings/errors:
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/rng/brcm,bcm2835.example.dt.yaml: rng@...04180: 'resets' does not match any of the regexes: 'pinctrl-[0-9]+'
	From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/rng/brcm,bcm2835.yaml

See https://patchwork.ozlabs.org/patch/1447144

This check can fail if there are any dependencies. The base for a patch
series is generally the most recent rc1.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit.