linux-kernel - Re: [PATCH 2/3] clocksource/drivers/timer-ti-dm: Remove extra of_node

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 4 Mar 2021 22:55:27 +0200
From:   Grygorii Strashko <grygorii.strashko@...com>
To:     Tony Lindgren <tony@...mide.com>,
        Daniel Lezcano <daniel.lezcano@...aro.org>,
        Thomas Gleixner <tglx@...utronix.de>
CC:     Keerthy <j-keerthy@...com>, <linux-kernel@...r.kernel.org>,
        <linux-omap@...r.kernel.org>,
        <linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH 2/3] clocksource/drivers/timer-ti-dm: Remove extra
 of_node_put()



On 04/03/2021 09:21, Tony Lindgren wrote:
> We have of_translate_address() already do of_node_put() as needed.
> I probably looked at __of_translate_address() earlier by accident
> that of_translate_address() uses.

I do not see of_node_put() in of_translate_address() and
  __of_translate_address() is doing of_node_get(dev);
?

> 
> Fixes: 52762fbd1c47 ("clocksource/drivers/timer-ti-dm: Add clockevent and clocksource support")
> Signed-off-by: Tony Lindgren <tony@...mide.com>
> ---
>   drivers/clocksource/timer-ti-dm-systimer.c | 2 --
>   1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/clocksource/timer-ti-dm-systimer.c b/drivers/clocksource/timer-ti-dm-systimer.c
> --- a/drivers/clocksource/timer-ti-dm-systimer.c
> +++ b/drivers/clocksource/timer-ti-dm-systimer.c
> @@ -265,7 +265,6 @@ static void __init dmtimer_systimer_assign_alwon(void)
>   				    pa == 0x48318000)
>   					continue;
>   
> -				of_node_put(np);
>   				break;
>   			}
>   		}
> @@ -300,7 +299,6 @@ static u32 __init dmtimer_systimer_find_first_available(void)
>   				continue;
>   			}
>   
> -			of_node_put(np);
>   			break;
>   		}
>   	}
> 

-- 
Best regards,
grygorii