linux-kernel - Re: drivers/gpu/drm/msm/dp/dp_hpd.c:37 dp_hpd_connect() error: we previously assumed 'hpd_priv->dp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <3e209334ecda37998ba7bc0982b1a463@codeaurora.org>
Date:   Wed, 03 Mar 2021 16:26:47 -0800
From:   abhinavk@...eaurora.org
To:     Dan Carpenter <dan.carpenter@...cle.com>
Cc:     kbuild@...ts.01.org, Chandan Uddaraju <chandanu@...eaurora.org>,
        lkp@...el.com, kbuild-all@...ts.01.org,
        linux-kernel@...r.kernel.org, Rob Clark <robdclark@...omium.org>,
        Vara Reddy <varar@...eaurora.org>,
        Tanmay Shah <tanmay@...eaurora.org>,
        Kuogee Hsieh <khsieh@...eaurora.org>,
        Guenter Roeck <groeck@...omium.org>,
        Stephen Boyd <swboyd@...omium.org>
Subject: Re: drivers/gpu/drm/msm/dp/dp_hpd.c:37 dp_hpd_connect() error: we
 previously assumed 'hpd_priv->dp_cb' could be null (see line 37)

Hi Dan

Thanks for reporting this, will submit a change to fix this.

Abhinav

On 2021-02-28 23:02, Dan Carpenter wrote:
> tree:
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
> master
> head:   fe07bfda2fb9cdef8a4d4008a409bb02f35f1bd8
> commit: c943b4948b5848fc0e07f875edbd35a973879e22 drm/msm/dp: add
> displayPort driver support
> config: arm64-randconfig-m031-20210301 (attached as .config)
> compiler: aarch64-linux-gcc (GCC) 9.3.0
> 
> If you fix the issue, kindly add following tag as appropriate
> Reported-by: kernel test robot <lkp@...el.com>
> Reported-by: Dan Carpenter <dan.carpenter@...cle.com>
> 
> smatch warnings:
> drivers/gpu/drm/msm/dp/dp_hpd.c:37 dp_hpd_connect() error: we
> previously assumed 'hpd_priv->dp_cb' could be null (see line 37)
> drivers/gpu/drm/msm/dp/dp_power.c:203 dp_power_clk_enable() warn:
> inconsistent indenting
> 
> vim +37 drivers/gpu/drm/msm/dp/dp_hpd.c
> 
> c943b4948b5848 Chandan Uddaraju 2020-08-27  27  static int
> dp_hpd_connect(struct dp_usbpd *dp_usbpd, bool hpd)
> c943b4948b5848 Chandan Uddaraju 2020-08-27  28  {
> c943b4948b5848 Chandan Uddaraju 2020-08-27  29  	int rc = 0;
> c943b4948b5848 Chandan Uddaraju 2020-08-27  30  	struct dp_hpd_private
> *hpd_priv;
> c943b4948b5848 Chandan Uddaraju 2020-08-27  31
> c943b4948b5848 Chandan Uddaraju 2020-08-27  32  	hpd_priv =
> container_of(dp_usbpd, struct dp_hpd_private,
> c943b4948b5848 Chandan Uddaraju 2020-08-27  33  					dp_usbpd);
> c943b4948b5848 Chandan Uddaraju 2020-08-27  34
> c943b4948b5848 Chandan Uddaraju 2020-08-27  35  	dp_usbpd->hpd_high = 
> hpd;
> c943b4948b5848 Chandan Uddaraju 2020-08-27  36
> c943b4948b5848 Chandan Uddaraju 2020-08-27 @37  	if (!hpd_priv->dp_cb
> && !hpd_priv->dp_cb->configure
> 
> ^^^^^^^^^^^^^^^^    ^^^^^^^^^^^^^^^^^^^^^^^^^^^
> Probably || was intended instead of &&.  If "hpd_priv->dp_cb" is NULL
> this will Oops.
> 
> c943b4948b5848 Chandan Uddaraju 2020-08-27  38  				&&
> !hpd_priv->dp_cb->disconnect) {
> c943b4948b5848 Chandan Uddaraju 2020-08-27  39  		pr_err("hpd dp_cb
> not initialized\n");
> c943b4948b5848 Chandan Uddaraju 2020-08-27  40  		return -EINVAL;
> c943b4948b5848 Chandan Uddaraju 2020-08-27  41  	}
> c943b4948b5848 Chandan Uddaraju 2020-08-27  42  	if (hpd)
> c943b4948b5848 Chandan Uddaraju 2020-08-27  43
> 		hpd_priv->dp_cb->configure(hpd_priv->dev);
> c943b4948b5848 Chandan Uddaraju 2020-08-27  44  	else
> c943b4948b5848 Chandan Uddaraju 2020-08-27  45
> 		hpd_priv->dp_cb->disconnect(hpd_priv->dev);
> c943b4948b5848 Chandan Uddaraju 2020-08-27  46
> c943b4948b5848 Chandan Uddaraju 2020-08-27  47  	return rc;
> c943b4948b5848 Chandan Uddaraju 2020-08-27  48  }
> 
> ---
> 0-DAY CI Kernel Test Service, Intel Corporation
> https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org