linux-kernel - Re: [PATCH v9 17/18] virt: acrn: Introduce an interface for Service VM to control vCPU

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210304013657.GC9695@shuo-intel.sh.intel.com>
Date:   Thu, 4 Mar 2021 09:36:57 +0800
From:   Shuo A Liu <shuo.a.liu@...el.com>
To:     Borislav Petkov <bp@...en8.de>
Cc:     linux-kernel@...r.kernel.org, x86@...nel.org,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        "H . Peter Anvin" <hpa@...or.com>,
        Thomas Gleixner <tglx@...utronix.de>,
        Ingo Molnar <mingo@...hat.com>, Yu Wang <yu1.wang@...el.com>,
        Reinette Chatre <reinette.chatre@...el.com>,
        Zhi Wang <zhi.a.wang@...el.com>,
        Zhenyu Wang <zhenyuw@...ux.intel.com>
Subject: Re: [PATCH v9 17/18] virt: acrn: Introduce an interface for Service
 VM to control vCPU

On Wed  3.Mar'21 at 18:37:19 +0100, Borislav Petkov wrote:
>On Sun, Feb 07, 2021 at 11:10:39AM +0800, shuo.a.liu@...el.com wrote:
>> From: Shuo Liu <shuo.a.liu@...el.com>
>>
>> ACRN supports partition mode to achieve real-time requirements. In
>> partition mode, a CPU core can be dedicated to a vCPU of User VM. The
>> local APIC of the dedicated CPU core can be passthrough to the User VM.
>> The Service VM controls the assignment of the CPU cores.
>>
>> Introduce an interface for the Service VM to remove the control of CPU
>> core from hypervisor perspective so that the CPU core can be a dedicated
>> CPU core of User VM.
>>
>> Signed-off-by: Shuo Liu <shuo.a.liu@...el.com>
>> Reviewed-by: Zhi Wang <zhi.a.wang@...el.com>
>> Reviewed-by: Reinette Chatre <reinette.chatre@...el.com>
>> Cc: Zhi Wang <zhi.a.wang@...el.com>
>> Cc: Zhenyu Wang <zhenyuw@...ux.intel.com>
>> Cc: Yu Wang <yu1.wang@...el.com>
>> Cc: Reinette Chatre <reinette.chatre@...el.com>
>> Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
>> ---
>>  drivers/virt/acrn/hsm.c       | 48 +++++++++++++++++++++++++++++++++++
>>  drivers/virt/acrn/hypercall.h | 14 ++++++++++
>>  2 files changed, 62 insertions(+)
>
>This one causes:
>
>drivers/virt/acrn/hsm.c: In function ‘remove_cpu_store’:
>drivers/virt/acrn/hsm.c:389:3: error: implicit declaration of function ‘remove_cpu’; did you mean ‘register_cpu’? [-Werror=implicit-function-declaration]
>   remove_cpu(cpu);
>   ^~~~~~~~~~
>   register_cpu
>drivers/virt/acrn/hsm.c:402:2: error: implicit declaration of function ‘add_cpu’; did you mean ‘task_cpu’? [-Werror=implicit-function-declaration]
>  add_cpu(cpu);
>  ^~~~~~~
>  task_cpu
>cc1: some warnings being treated as errors
>make[3]: *** [scripts/Makefile.build:271: drivers/virt/acrn/hsm.o] Error 1
>make[3]: *** Waiting for unfinished jobs....
>make[2]: *** [scripts/Makefile.build:514: drivers/virt/acrn] Error 2
>make[1]: *** [scripts/Makefile.build:514: drivers/virt] Error 2
>make[1]: *** Waiting for unfinished jobs....
>make: *** [Makefile:1849: drivers] Error 2

This patchset could fix it.
https://lore.kernel.org/lkml/20210221134339.57851-1-shuo.a.liu@intel.com/.

Thanks
shuo