linux-kernel - Re: [PATCH] Documentation/admin-guide: kernel-parameters: correct the architectures for numa

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 03 Mar 2021 18:26:32 -0800 (PST)
From:   Palmer Dabbelt <palmer@...belt.com>
To:     song.bao.hua@...ilicon.com
CC:     corbet@....net, linux-doc@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-riscv@...ts.infradead.org,
        song.bao.hua@...ilicon.com, mgorman@...e.de,
        Paul Walmsley <paul.walmsley@...ive.com>,
        aou@...s.berkeley.edu, paulmck@...nel.org, rdunlap@...radead.org,
        akpm@...ux-foundation.org, tglx@...utronix.de,
        mchehab+huawei@...nel.org, viresh.kumar@...aro.org,
        mike.kravetz@...cle.com, peterz@...radead.org
Subject:     Re: [PATCH] Documentation/admin-guide: kernel-parameters: correct the architectures for numa_balancing

On Tue, 02 Mar 2021 00:41:59 PST (-0800), song.bao.hua@...ilicon.com wrote:
> X86 isn't the only architecture supporting NUMA_BALANCING. ARM64, PPC,
> S390 and RISCV also support it:
>
> arch$ git grep NUMA_BALANCING
> arm64/Kconfig:  select ARCH_SUPPORTS_NUMA_BALANCING
> arm64/configs/defconfig:CONFIG_NUMA_BALANCING=y
> arm64/include/asm/pgtable.h:#ifdef CONFIG_NUMA_BALANCING
> powerpc/configs/powernv_defconfig:CONFIG_NUMA_BALANCING=y
> powerpc/configs/ppc64_defconfig:CONFIG_NUMA_BALANCING=y
> powerpc/configs/pseries_defconfig:CONFIG_NUMA_BALANCING=y
> powerpc/include/asm/book3s/64/pgtable.h:#ifdef CONFIG_NUMA_BALANCING
> powerpc/include/asm/book3s/64/pgtable.h:#ifdef CONFIG_NUMA_BALANCING
> powerpc/include/asm/book3s/64/pgtable.h:#endif /* CONFIG_NUMA_BALANCING */
> powerpc/include/asm/book3s/64/pgtable.h:#ifdef CONFIG_NUMA_BALANCING
> powerpc/include/asm/book3s/64/pgtable.h:#endif /* CONFIG_NUMA_BALANCING */
> powerpc/include/asm/nohash/pgtable.h:#ifdef CONFIG_NUMA_BALANCING
> powerpc/include/asm/nohash/pgtable.h:#endif /* CONFIG_NUMA_BALANCING */
> powerpc/platforms/Kconfig.cputype:      select ARCH_SUPPORTS_NUMA_BALANCING
> riscv/Kconfig:  select ARCH_SUPPORTS_NUMA_BALANCING
> riscv/include/asm/pgtable.h:#ifdef CONFIG_NUMA_BALANCING
> s390/Kconfig:   select ARCH_SUPPORTS_NUMA_BALANCING
> s390/configs/debug_defconfig:CONFIG_NUMA_BALANCING=y
> s390/configs/defconfig:CONFIG_NUMA_BALANCING=y
> s390/include/asm/pgtable.h:#ifdef CONFIG_NUMA_BALANCING
> x86/Kconfig:    select ARCH_SUPPORTS_NUMA_BALANCING     if X86_64
> x86/include/asm/pgtable.h:#ifdef CONFIG_NUMA_BALANCING
> x86/include/asm/pgtable.h:#endif /* CONFIG_NUMA_BALANCING */
>
> On the other hand, setup_numabalancing() is implemented in mm/mempolicy.c
> which doesn't depend on architectures.
>
> Cc: Mel Gorman <mgorman@...e.de>
> Cc: Paul Walmsley <paul.walmsley@...ive.com>
> Cc: Palmer Dabbelt <palmer@...belt.com>
> Cc: Albert Ou <aou@...s.berkeley.edu>
> Cc: "Paul E. McKenney" <paulmck@...nel.org>
> Cc: Randy Dunlap <rdunlap@...radead.org>
> Cc: Andrew Morton <akpm@...ux-foundation.org>
> Cc: Thomas Gleixner <tglx@...utronix.de>
> Cc: Mauro Carvalho Chehab <mchehab+huawei@...nel.org>
> Cc: Viresh Kumar <viresh.kumar@...aro.org>
> Cc: Mike Kravetz <mike.kravetz@...cle.com>
> Cc: Peter Zijlstra <peterz@...radead.org>
> Signed-off-by: Barry Song <song.bao.hua@...ilicon.com>
> ---
>  Documentation/admin-guide/kernel-parameters.rst | 1 +
>  Documentation/admin-guide/kernel-parameters.txt | 3 ++-
>  2 files changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/admin-guide/kernel-parameters.rst b/Documentation/admin-guide/kernel-parameters.rst
> index 1132796a8d96..24302cad174a 100644
> --- a/Documentation/admin-guide/kernel-parameters.rst
> +++ b/Documentation/admin-guide/kernel-parameters.rst
> @@ -140,6 +140,7 @@ parameter is applicable::
>  	PPT	Parallel port support is enabled.
>  	PS2	Appropriate PS/2 support is enabled.
>  	RAM	RAM disk support is enabled.
> +	RISCV	RISCV architecture is enabled.
>  	RDT	Intel Resource Director Technology.
>  	S390	S390 architecture is enabled.
>  	SCSI	Appropriate SCSI support is enabled.
> diff --git a/Documentation/admin-guide/kernel-parameters.txt b/Documentation/admin-guide/kernel-parameters.txt
> index 04545725f187..371a02ae1e21 100644
> --- a/Documentation/admin-guide/kernel-parameters.txt
> +++ b/Documentation/admin-guide/kernel-parameters.txt
> @@ -3472,7 +3472,8 @@
>
>  	nr_uarts=	[SERIAL] maximum number of UARTs to be registered.
>
> -	numa_balancing=	[KNL,X86] Enable or disable automatic NUMA balancing.
> +	numa_balancing=	[KNL,ARM64,PPC,RISCV,S390,X86] Enable or disable automatic
> +			NUMA balancing.
>  			Allowed values are enable and disable
>
>  	numa_zonelist_order= [KNL, BOOT] Select zonelist order for NUMA.

Reviewed-by: Palmer Dabbelt <palmerdabbelt@...gle.com>
Acked-by: Palmer Dabbelt <palmerdabbelt@...gle.com>