linux-kernel - Re: [PATCH] scsi: ufs: Fix incorrect ufshcd_state after ufshcd_reset_and

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <161483137625.31239.965550193595620091.b4-ty@oracle.com>
Date:   Wed,  3 Mar 2021 23:16:37 -0500
From:   "Martin K. Petersen" <martin.petersen@...cle.com>
To:     Adrian Hunter <adrian.hunter@...el.com>,
        "James E . J . Bottomley" <jejb@...ux.ibm.com>
Cc:     "Martin K . Petersen" <martin.petersen@...cle.com>,
        Alim Akhtar <alim.akhtar@...sung.com>,
        Can Guo <cang@...eaurora.org>, Bean Huo <huobean@...il.com>,
        linux-kernel@...r.kernel.org,
        Asutosh Das <asutoshd@...eaurora.org>,
        Avri Altman <avri.altman@....com>,
        Stanley Chu <stanley.chu@...iatek.com>,
        linux-scsi@...r.kernel.org
Subject: Re: [PATCH] scsi: ufs: Fix incorrect ufshcd_state after ufshcd_reset_and_restore()

On Mon, 1 Mar 2021 21:19:40 +0200, Adrian Hunter wrote:

> If ufshcd_probe_hba() fails it sets ufshcd_state to UFSHCD_STATE_ERROR,
> however, if it is called again, as it is within a loop in
> ufshcd_reset_and_restore(), and succeeds, then it will not set the state
> back to UFSHCD_STATE_OPERATIONAL unless the state was
> UFSHCD_STATE_RESET.
> 
> That can result in the state being UFSHCD_STATE_ERROR even though
> ufshcd_reset_and_restore() is successful and returns zero.
> 
> [...]

Applied to 5.12/scsi-fixes, thanks!

[1/1] scsi: ufs: Fix incorrect ufshcd_state after ufshcd_reset_and_restore()
      https://git.kernel.org/mkp/scsi/c/02c2fc6acc43

-- 
Martin K. Petersen	Oracle Linux Engineering