linux-kernel - Re: [PATCH v7 00/11] Regression fixes/clean ups in the Qualcomm crypto engine driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 4 Mar 2021 17:42:54 +1100
From:   Herbert Xu <herbert@...dor.apana.org.au>
To:     Thara Gopinath <thara.gopinath@...aro.org>
Cc:     davem@...emloft.net, bjorn.andersson@...aro.org,
        ebiggers@...gle.com, ardb@...nel.org, sivaprak@...eaurora.org,
        linux-crypto@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v7 00/11] Regression fixes/clean ups in the Qualcomm
 crypto engine driver

On Thu, Feb 11, 2021 at 03:01:17PM -0500, Thara Gopinath wrote:
> This patch series is a result of running kernel crypto fuzz tests (by
> enabling CONFIG_CRYPTO_MANAGER_EXTRA_TESTS) on the transformations
> currently supported via the Qualcomm crypto engine on sdm845.  The first
> nine patches are fixes for various regressions found during testing. The
> last two patches are minor clean ups of unused variable and parameters.
> 
> v6->v7:
> 	- Fixed sparse warning in patch 4 as pointed out by Herbert Xu.
> 	  This means the checking if any two keys are same for triple
> 	  des algorithms has been reverted back to using conditional OR
> 	  instead of using bitwise OR.
> 	- Rebased to 5.11-rc7.
> 
> v5->v6:
> 	- Return 0 for zero length messages instead of -EOPNOTSUPP in the
> 	  cipher algorithms as pointed out by Eric Biggers.
> 	- Remove the wrong TODO in patch 6 which implied that AES CBC can
> 	  do partial block sizes when it is actually CTS mode that can as
> 	  pointed out my Eric Biggers.
> 
> v4->v5:
> 	- Fixed build warning/error in patch for wrong assignment of const
> 	  pointer as reported by kernel test robot <lkp@...el.com>.
> 	- Rebased to 5.11-rc6.
> v3->v4:
> 	- Fixed the bug where only two bytes of byte_count were getting
> 	  saved and restored instead of all eight bytes. Thanks Bjorn for
> 	  catching this.
> 	- Split patch 3 "Fix regressions found during fuzz testing" into
> 	  6 patches as requested by Bjorn.
> 	- Dropped crypto from all subject headers.
> 	- Rebased to 5.11-rc5
> v2->v3:
>         - Made the comparison between keys to check if any two keys are
>           same for triple des algorithms constant-time as per
>           Nym Seddon's suggestion.
>         - Rebased to 5.11-rc4.
> v1->v2:
>         - Introduced custom struct qce_sha_saved_state to store and restore
>           partial sha transformation.
>         - Rebased to 5.11-rc3.
> 
> Thara Gopinath (11):
>   crypto: qce: sha: Restore/save ahash state with custom struct in
>     export/import
>   crypto: qce: sha: Hold back a block of data to be transferred as part
>     of final
>   crypto: qce: skcipher: Return unsupported if key1 and key 2 are same
>     for AES XTS algorithm
>   crypto: qce: skcipher: Return unsupported if any three keys are same
>     for DES3 algorithms
>   crypto: qce: skcipher: Return error for zero length messages
>   crypto: qce: skcipher: Return error for non-blocksize data(ECB/CBC
>     algorithms)
>   crypto: qce: skcipher: Set ivsize to 0 for ecb(aes)
> *** BLURB HERE ***
> 
> Thara Gopinath (11):
>   crypto: qce: sha: Restore/save ahash state with custom struct in
>     export/import
>   crypto: qce: sha: Hold back a block of data to be transferred as part
>     of final
>   crypto: qce: skcipher: Return unsupported if key1 and key 2 are same
>     for AES XTS algorithm
>   crypto: qce: skcipher: Return unsupported if any three keys are same
>     for DES3 algorithms
>   crypto: qce: skcipher: Return error for zero length messages
>   crypto: qce: skcipher: Return error for non-blocksize data(ECB/CBC
>     algorithms)
>   crypto: qce: skcipher: Set ivsize to 0 for ecb(aes)
>   crypto: qce: skcipher: Improve the conditions for requesting AES
>     fallback cipher
>   crypto: qce: common: Set data unit size to message length for AES XTS
>     transformation
>   crypto: qce: Remover src_tbl from qce_cipher_reqctx
>   crypto: qce: Remove totallen and offset in qce_start
> 
>  drivers/crypto/qce/cipher.h   |   1 -
>  drivers/crypto/qce/common.c   |  25 +++---
>  drivers/crypto/qce/common.h   |   3 +-
>  drivers/crypto/qce/sha.c      | 143 +++++++++++++---------------------
>  drivers/crypto/qce/skcipher.c |  69 +++++++++++++---
>  5 files changed, 126 insertions(+), 115 deletions(-)

All applied.  Thanks.
-- 
Email: Herbert Xu <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt