linux-kernel - Re: [PATCH 1/2] units: Add the HZ_PER

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHp75Vd5u1jHKPALfBTTqEoXf-4OAdLhsn3A-fzPw3Me=7hhMA@mail.gmail.com>
Date:   Thu, 4 Mar 2021 11:38:56 +0200
From:   Andy Shevchenko <andy.shevchenko@...il.com>
To:     Andrew Morton <akpm@...ux-foundation.org>
Cc:     Daniel Lezcano <daniel.lezcano@...aro.org>,
        "rafael@...nel.org" <rafael@...nel.org>,
        Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        Lukasz Luba <lukasz.luba@....com>,
        open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/2] units: Add the HZ_PER_KHZ macro

On Thu, Mar 4, 2021 at 2:31 AM Andrew Morton <akpm@...ux-foundation.org> wrote:
> On Wed, 24 Feb 2021 10:39:36 +0200 Andy Shevchenko <andy.shevchenko@...il.com> wrote:

...

> Also, why make them signed types?  Negative Hz is physically
> nonsensical.  If that upsets some code somewhere because it was dealing
> with signed types then, well, that code needed fixing anyway.
>
> Ditto MILLIWATT_PER_WATT and friends, sigh.

And all seconds also. I guess it's historically like this and in any
case I don't expect we will have multipliers that don't fit long long.

There might be some subtle integral promotion rules that screw the
flow up, but I have not much experience with it to be honest.

-- 
With Best Regards,
Andy Shevchenko