linux-kernel - Re: [PATCH 08/30] scsi: pm8001: pm8001_init: Provide function name and fix a misspelling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAMGffEmcyspgsigH3Ek-O=VR+t3Hpx2aBtw04domWQ1Snm7xpg@mail.gmail.com>
Date:   Thu, 4 Mar 2021 10:51:37 +0100
From:   Jinpu Wang <jinpu.wang@...ud.ionos.com>
To:     Lee Jones <lee.jones@...aro.org>
Cc:     open list <linux-kernel@...r.kernel.org>,
        "James E.J. Bottomley" <jejb@...ux.ibm.com>,
        "Martin K. Petersen" <martin.petersen@...cle.com>,
        Kumar Santhanam <AnandKumar.Santhanam@...s.com>,
        Sangeetha Gnanasekaran <Sangeetha.Gnanasekaran@...s.com>,
        Nikith Ganigarakoppal <Nikith.Ganigarakoppal@...s.com>,
        Linux SCSI Mailinglist <linux-scsi@...r.kernel.org>
Subject: Re: [PATCH 08/30] scsi: pm8001: pm8001_init: Provide function name
 and fix a misspelling

On Wed, Mar 3, 2021 at 3:46 PM Lee Jones <lee.jones@...aro.org> wrote:
>
> Fixes the following W=1 kernel build warning(s):
>
>  drivers/scsi/pm8001/pm8001_init.c:192: warning: expecting prototype for tasklet for 64 msi(). Prototype was for pm8001_tasklet() instead
>  drivers/scsi/pm8001/pm8001_init.c:872: warning: expecting prototype for pm8001_set_phy_settings_ven_117c_12Gb(). Prototype was for pm8001_set_phy_settings_ven_117c_12G() instead
>
> Cc: Jack Wang <jinpu.wang@...ud.ionos.com>
> Cc: "James E.J. Bottomley" <jejb@...ux.ibm.com>
> Cc: "Martin K. Petersen" <martin.petersen@...cle.com>
> Cc: Kumar Santhanam <AnandKumar.Santhanam@...s.com>
> Cc: Sangeetha Gnanasekaran <Sangeetha.Gnanasekaran@...s.com>
> Cc: Nikith Ganigarakoppal <Nikith.Ganigarakoppal@...s.com>
> Cc: linux-scsi@...r.kernel.org
> Signed-off-by: Lee Jones <lee.jones@...aro.org>
Acked-by: Jack Wang <jinpu.wang@...ud.ionos.com>
Thanks
> ---
>  drivers/scsi/pm8001/pm8001_init.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/scsi/pm8001/pm8001_init.c b/drivers/scsi/pm8001/pm8001_init.c
> index bd626ef876dac..bbb6b23aa6b1c 100644
> --- a/drivers/scsi/pm8001/pm8001_init.c
> +++ b/drivers/scsi/pm8001/pm8001_init.c
> @@ -184,7 +184,7 @@ static void pm8001_free(struct pm8001_hba_info *pm8001_ha)
>  #ifdef PM8001_USE_TASKLET
>
>  /**
> - * tasklet for 64 msi-x interrupt handler
> + * pm8001_tasklet() - tasklet for 64 msi-x interrupt handler
>   * @opaque: the passed general host adapter struct
>   * Note: pm8001_tasklet is common for pm8001 & pm80xx
>   */
> @@ -864,7 +864,7 @@ void pm8001_get_phy_mask(struct pm8001_hba_info *pm8001_ha, int *phymask)
>  }
>
>  /**
> - * pm8001_set_phy_settings_ven_117c_12Gb : Configure ATTO 12Gb PHY settings
> + * pm8001_set_phy_settings_ven_117c_12G() : Configure ATTO 12Gb PHY settings
>   * @pm8001_ha : our adapter
>   */
>  static
> --
> 2.27.0
>