linux-kernel - Re: [PATCH v4 06/13] phy: cadence: cadence-sierra: Move all reset_control

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 04 Mar 2021 12:54:21 +0100
From:   Philipp Zabel <p.zabel@...gutronix.de>
To:     Kishon Vijay Abraham I <kishon@...com>,
        Vinod Koul <vkoul@...nel.org>,
        Rob Herring <robh+dt@...nel.org>,
        Swapnil Jakhade <sjakhade@...ence.com>
Cc:     linux-kernel@...r.kernel.org, devicetree@...r.kernel.org,
        Lokesh Vutla <lokeshvutla@...com>
Subject: Re: [PATCH v4 06/13] phy: cadence: cadence-sierra: Move all
 reset_control_get*() to a separate function

On Thu, 2021-03-04 at 10:11 +0530, Kishon Vijay Abraham I wrote:
> No functional change. Group devm_reset_control_get() and
> devm_reset_control_get_optional() to a separate function.
> 
> Signed-off-by: Kishon Vijay Abraham I <kishon@...com>
> ---
>  drivers/phy/cadence/phy-cadence-sierra.c | 36 ++++++++++++++++--------
>  1 file changed, 25 insertions(+), 11 deletions(-)
> 
> diff --git a/drivers/phy/cadence/phy-cadence-sierra.c b/drivers/phy/cadence/phy-cadence-sierra.c
> index 7bf1b4c7774a..935f165404e4 100644
> --- a/drivers/phy/cadence/phy-cadence-sierra.c
> +++ b/drivers/phy/cadence/phy-cadence-sierra.c
> @@ -509,6 +509,28 @@ static int cdns_sierra_phy_get_clocks(struct cdns_sierra_phy *sp,
>  	return 0;
>  }
>  
> +static int cdns_sierra_phy_get_resets(struct cdns_sierra_phy *sp,
> +				      struct device *dev)
> +{
> +	struct reset_control *rst;
> +
> +	rst = devm_reset_control_get(dev, "sierra_reset");

Please use
	rst = devm_reset_control_get_exclusive(dev, "sierra_reset");
here ...

> +	if (IS_ERR(rst)) {
> +		dev_err(dev, "failed to get reset\n");
> +		return PTR_ERR(rst);
> +	}
> +	sp->phy_rst = rst;
> +
> +	rst = devm_reset_control_get_optional(dev, "sierra_apb");

... and
	rst = devm_reset_control_get_optional_exclusive(dev, "sierra_apb");	
here (no functional change).

With that,

Reviewed-by: Philipp Zabel <p.zabel@...gutronix.de>

regards
Philipp