linux-kernel - Re: [PATCH v4 01/13] phy: cadence: Sierra: Fix PHY power

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 04 Mar 2021 12:56:41 +0100
From:   Philipp Zabel <p.zabel@...gutronix.de>
To:     Kishon Vijay Abraham I <kishon@...com>,
        Vinod Koul <vkoul@...nel.org>,
        Rob Herring <robh+dt@...nel.org>,
        Swapnil Jakhade <sjakhade@...ence.com>
Cc:     linux-kernel@...r.kernel.org, devicetree@...r.kernel.org,
        Lokesh Vutla <lokeshvutla@...com>, stable@...r.kernel.org
Subject: Re: [PATCH v4 01/13] phy: cadence: Sierra: Fix PHY power_on sequence

On Thu, 2021-03-04 at 10:11 +0530, Kishon Vijay Abraham I wrote:
> Commit 44d30d622821d ("phy: cadence: Add driver for Sierra PHY")
> de-asserts PHY_RESET even before the configurations are loaded in
> phy_init(). However PHY_RESET should be de-asserted only after
> all the configurations has been initialized, instead of de-asserting
> in probe. Fix it here.
> 
> Fixes: 44d30d622821d ("phy: cadence: Add driver for Sierra PHY")
> Signed-off-by: Kishon Vijay Abraham I <kishon@...com>
> Cc: <stable@...r.kernel.org> # v5.4+

Reviewed-by: Philipp Zabel <p.zabel@...gutronix.de>

regards
Philipp