linux-kernel - Re: [PATCH 05/10] crypto: keembay: ocs-hcu: Fix incorrectly named functions/structs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <7d54b93328abe346c57f73886f8104630a5b82be.camel@intel.com>
Date:   Thu, 4 Mar 2021 12:02:02 +0000
From:   "Alessandrelli, Daniele" <daniele.alessandrelli@...el.com>
To:     "lee.jones@...aro.org" <lee.jones@...aro.org>
CC:     "linux-crypto@...r.kernel.org" <linux-crypto@...r.kernel.org>,
        "Murphy, Declan" <declan.murphy@...el.com>,
        "herbert@...dor.apana.org.au" <herbert@...dor.apana.org.au>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "davem@...emloft.net" <davem@...emloft.net>
Subject: Re: [PATCH 05/10] crypto: keembay: ocs-hcu: Fix incorrectly named
 functions/structs

Hi Lee,

Thanks for the patch.

On Wed, 2021-03-03 at 14:34 +0000, Lee Jones wrote:
> Fixes the following W=1 kernel build warning(s):
> 
>  drivers/crypto/keembay/ocs-hcu.c:107: warning: expecting prototype for struct ocs_hcu_dma_list. Prototype was for struct ocs_hcu_dma_entry instead
>  drivers/crypto/keembay/ocs-hcu.c:127: warning: expecting prototype for struct ocs_dma_list. Prototype was for struct ocs_hcu_dma_list instead

I don't see the fix for this in the diff. Am I missing something?

>  drivers/crypto/keembay/ocs-hcu.c:610: warning: expecting prototype for ocs_hcu_digest(). Prototype was for ocs_hcu_hash_update() instead
>  drivers/crypto/keembay/ocs-hcu.c:648: warning: expecting prototype for ocs_hcu_hash_final(). Prototype was for ocs_hcu_hash_finup() instead
> 
> Cc: Daniele Alessandrelli <daniele.alessandrelli@...el.com>
> Cc: Declan Murphy <declan.murphy@...el.com>
> Cc: Herbert Xu <herbert@...dor.apana.org.au>
> Cc: "David S. Miller" <davem@...emloft.net>
> Cc: linux-crypto@...r.kernel.org
> Signed-off-by: Lee Jones <lee.jones@...aro.org>
> ---
>  drivers/crypto/keembay/ocs-hcu.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/crypto/keembay/ocs-hcu.c b/drivers/crypto/keembay/ocs-hcu.c
> index 81eecacf603ad..d522757855fb0 100644
> --- a/drivers/crypto/keembay/ocs-hcu.c
> +++ b/drivers/crypto/keembay/ocs-hcu.c
> @@ -93,7 +93,7 @@
>  #define OCS_HCU_WAIT_BUSY_TIMEOUT_US		1000000
>  
>  /**
> - * struct ocs_hcu_dma_list - An entry in an OCS DMA linked list.
> + * struct ocs_hcu_dma_entry - An entry in an OCS DMA linked list.
>   * @src_addr:  Source address of the data.
>   * @src_len:   Length of data to be fetched.
>   * @nxt_desc:  Next descriptor to fetch.
> @@ -597,7 +597,7 @@ int ocs_hcu_hash_init(struct ocs_hcu_hash_ctx *ctx, enum ocs_hcu_algo algo)
>  }
>  
>  /**
> - * ocs_hcu_digest() - Perform a hashing iteration.
> + * ocs_hcu_hash_update() - Perform a hashing iteration.
>   * @hcu_dev:	The OCS HCU device to use.
>   * @ctx:	The OCS HCU hashing context.
>   * @dma_list:	The OCS DMA list mapping the input data to process.
> @@ -632,7 +632,7 @@ int ocs_hcu_hash_update(struct ocs_hcu_dev *hcu_dev,
>  }
>  
>  /**
> - * ocs_hcu_hash_final() - Update and finalize hash computation.
> + * ocs_hcu_hash_finup() - Update and finalize hash computation.
>   * @hcu_dev:	The OCS HCU device to use.
>   * @ctx:	The OCS HCU hashing context.
>   * @dma_list:	The OCS DMA list mapping the input data to process.