linux-kernel - Re: [PATCH] iommu/vt-d: Fix status code for Allocate/Free PASID command

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20210304123231.GE26414@8bytes.org>
Date:   Thu, 4 Mar 2021 13:32:31 +0100
From:   Joerg Roedel <joro@...tes.org>
To:     Zenghui Yu <yuzenghui@...wei.com>
Cc:     iommu@...ts.linux-foundation.org, linux-kernel@...r.kernel.org,
        dwmw2@...radead.org, baolu.lu@...ux.intel.com, will@...nel.org,
        jacob.jun.pan@...ux.intel.com, eric.auger@...hat.com,
        yi.l.liu@...el.com, kevin.tian@...el.com,
        wanghaibin.wang@...wei.com
Subject: Re: [PATCH] iommu/vt-d: Fix status code for Allocate/Free PASID
 command

On Sat, Feb 27, 2021 at 03:39:09PM +0800, Zenghui Yu wrote:
> As per Intel vt-d spec, Rev 3.0 (section 10.4.45 "Virtual Command Response
> Register"), the status code of "No PASID available" error in response to
> the Allocate PASID command is 2, not 1. The same for "Invalid PASID" error
> in response to the Free PASID command.
> 
> We will otherwise see confusing kernel log under the command failure from
> guest side. Fix it.
> 
> Fixes: 24f27d32ab6b ("iommu/vt-d: Enlightened PASID allocation")
> Signed-off-by: Zenghui Yu <yuzenghui@...wei.com>

Applied for v5.12, thanks.