[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <16d4300e-bf29-1e85-317b-53d257890cb9@vmware.com>
Date: Fri, 5 Mar 2021 16:33:01 +0100
From: Roland Scheidegger <sroland@...are.com>
To: Lee Jones <lee.jones@...aro.org>
Cc: linux-kernel@...r.kernel.org,
Alex Deucher <alexander.deucher@....com>,
amd-gfx@...ts.freedesktop.org, Anthony Koo <Anthony.Koo@....com>,
Ben Skeggs <bskeggs@...hat.com>,
Christian König <christian.koenig@....com>,
Colin Ian King <colin.king@...onical.com>,
Daniel Vetter <daniel@...ll.ch>,
Dave Airlie <airlied@...hat.com>,
David Airlie <airlied@...ux.ie>,
dri-devel@...ts.freedesktop.org, freedreno@...ts.freedesktop.org,
Harry Wentland <harry.wentland@....com>,
Jeremy Kolb <jkolb@...ndeis.edu>,
Kuogee Hsieh <khsieh@...eaurora.org>,
Leo Li <sunpeng.li@....com>, linaro-mm-sig@...ts.linaro.org,
linux-arm-msm@...r.kernel.org, linux-media@...r.kernel.org,
Lyude Paul <lyude@...hat.com>,
Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>,
Maxime Ripard <mripard@...nel.org>,
nouveau@...ts.freedesktop.org,
Qinglang Miao <miaoqinglang@...wei.com>,
Rob Clark <rob.clark@...aro.org>,
Rob Clark <robdclark@...il.com>, Sean Paul <sean@...rly.run>,
Sumit Semwal <sumit.semwal@...aro.org>,
Thomas Zimmermann <tzimmermann@...e.de>,
VMware Graphics <linux-graphics-maintainer@...are.com>,
Zack Rusin <zackr@...are.com>
Subject: Re: [RESEND 00/53] Rid GPU from W=1 warnings
The vmwgfx ones look all good to me, so for
23-53: Reviewed-by: Roland Scheidegger <sroland@...are.com>
That said, they were already signed off by Zack, so not sure what
happened here.
Roland
On 03.03.21 14:42, Lee Jones wrote:
> This is a resend. All of these patches have been sent before.
>
> The vmwgfx ones were even applied, but were dropped for some reason.
>
> Lee Jones (53):
> drm/nouveau/nvkm/subdev/bios/init: Demote obvious abuse of kernel-doc
> drm/nouveau/dispnv50/disp: Remove unused variable 'ret'
> drm/msm/dp/dp_display: Remove unused variable 'hpd'
> drm/amd/display/dc/bios/command_table: Remove unused variable
> include: drm: drm_atomic: Make use of 'new_plane_state'
> drm/nouveau/nvkm/subdev/volt/gk20a: Demote non-conformant kernel-doc
> headers
> drm/amd/display/dc/bios/command_table: Remove unused variable and
> associated comment
> drm/amd/display/dc/calcs/dce_calcs: Move some large variables from the
> stack to the heap
> drm/amd/display/dc/calcs/dce_calcs: Remove some large variables from
> the stack
> drm/amd/display/dc/dce/dce_aux: Remove duplicate line causing 'field
> overwritten' issue
> drm/amd/display/dc/dce80/dce80_resource: Make local functions static
> drm/nouveau/nvkm/engine/gr/gf100: Demote non-conformant kernel-doc
> header
> drm/nouveau/nouveau_bo: Remove unused variables 'dev'
> drm/nouveau/nouveau_display: Remove set but unused variable 'width'
> drm/nouveau/dispnv04/crtc: Demote non-conforming kernel-doc headers
> drm/nouveau/dispnv50/disp: Remove unused variable 'ret' from function
> returning void
> drm/nouveau/dispnv50/headc57d: Make local function 'headc57d_olut'
> static
> drm/nouveau/nv50_display: Remove superfluous prototype for local
> static functions
> drm/nouveau/dispnv50/disp: Include header containing our prototypes
> drm/nouveau/nouveau_ioc32: File headers are not good candidates for
> kernel-doc
> drm/nouveau/nouveau_svm: Remove unused variable 'ret' from void
> function
> drm/nouveau/nouveau_ioc32: Demote kernel-doc abuse to standard comment
> block
> drm/vmwgfx/vmwgfx_execbuf: Fix some kernel-doc related issues
> drm/vmwgfx/vmwgfx_kms: Remove unused variable 'ret' from
> 'vmw_du_primary_plane_atomic_check()'
> drm/vmwgfx/vmwgfx_kms: Mark vmw_{cursor,primary}_plane_formats as
> __maybe_unused
> drm/vmwgfx/vmwgfx_drv: Fix some kernel-doc misdemeanours
> drm/vmwgfx/vmwgfx_ioctl: Provide missing '@' sign required by
> kernel-doc
> drm/vmwgfx/vmwgfx_resource: Fix worthy function headers demote some
> others
> drm/vmwgfx/vmwgfx_ttm_buffer: Supply some missing parameter
> descriptions
> drm/vmwgfx/vmwgfx_fifo: Demote non-conformant kernel-doc header
> drm/vmwgfx/vmwgfx_ldu: Supply descriptions for 'state' function
> parameter
> drm/vmwgfx/vmwgfx_kms: Update worthy function headers and demote
> others
> drm/vmwgfx/vmwgfx_overlay: Demote kernel-doc abuses to standard
> comment blocks
> drm/vmwgfx/vmwgfx_fence: Add, remove and demote various documentation
> params/headers
> drm/vmwgfx/vmwgfx_bo: Remove superfluous param description and supply
> another
> drm/vmwgfx/vmwgfx_context: Demote kernel-doc abuses
> drm/vmwgfx/vmwgfx_scrn: Demote unworthy kernel-doc headers and update
> others
> drm/vmwgfx/vmwgfx_surface: Fix some kernel-doc related issues
> drm/vmwgfx/vmwgfx_cmdbuf_res: Rename param description and remove
> another
> drm/vmwgfx/vmwgfx_shader: Demote kernel-doc abuses and fix-up worthy
> headers
> drm/vmwgfx/vmwgfx_cmdbuf: Fix a bunch of missing or incorrectly
> formatted/named params
> drm/vmwgfx/vmwgfx_cmdbuf_res: Remove unused variable 'ret'
> drm/vmwgfx/vmwgfx_stdu: Add some missing param/member descriptions
> drm/vmwgfx/vmwgfx_cmdbuf: Fix misnaming of 'headers' should be plural
> drm/vmwgfx/vmwgfx_cotable: Fix a couple of simple documentation
> problems
> drm/vmwgfx/vmwgfx_so: Add description for 'vmw_view's 'rcu' member
> drm/vmwgfx/vmwgfx_binding: Provide some missing param descriptions and
> remove others
> drm/vmwgfx/vmwgfx_msg: Fix misspelling of 'msg'
> drm/vmwgfx/vmwgfx_blit: Add description for 'vmw_bo_cpu_blit's 'diff'
> param
> drm/vmwgfx/vmwgfx_validation: Add some missing struct member/function
> param descriptions
> drm/vmwgfx/ttm_object: Demote half-assed headers and fix-up another
> drm/vmwgfx/vmwgfx_thp: Add description for 'vmw_thp_manager's member
> 'manager'
> drm/vmwgfx/ttm_object: Reorder header to immediately precede its
> struct
>
> .../drm/amd/display/dc/bios/command_table.c | 16 +-
> .../gpu/drm/amd/display/dc/calcs/dce_calcs.c | 1151 +++++++++--------
> drivers/gpu/drm/amd/display/dc/dce/dce_aux.h | 1 -
> .../drm/amd/display/dc/dce80/dce80_resource.c | 16 +-
> drivers/gpu/drm/msm/dp/dp_display.c | 3 -
> drivers/gpu/drm/nouveau/dispnv04/crtc.c | 4 +-
> drivers/gpu/drm/nouveau/dispnv50/disp.c | 10 +-
> drivers/gpu/drm/nouveau/dispnv50/headc57d.c | 2 +-
> drivers/gpu/drm/nouveau/nouveau_bo.c | 4 -
> drivers/gpu/drm/nouveau/nouveau_display.c | 8 +-
> drivers/gpu/drm/nouveau/nouveau_ioc32.c | 4 +-
> drivers/gpu/drm/nouveau/nouveau_svm.c | 5 +-
> drivers/gpu/drm/nouveau/nv50_display.h | 3 -
> .../gpu/drm/nouveau/nvkm/engine/gr/gf100.c | 2 +-
> .../gpu/drm/nouveau/nvkm/subdev/bios/init.c | 204 +--
> .../gpu/drm/nouveau/nvkm/subdev/volt/gk20a.c | 4 +-
> drivers/gpu/drm/vmwgfx/ttm_object.c | 25 +-
> drivers/gpu/drm/vmwgfx/vmwgfx_binding.c | 9 +-
> drivers/gpu/drm/vmwgfx/vmwgfx_blit.c | 1 +
> drivers/gpu/drm/vmwgfx/vmwgfx_bo.c | 2 +-
> drivers/gpu/drm/vmwgfx/vmwgfx_cmd.c | 2 +-
> drivers/gpu/drm/vmwgfx/vmwgfx_cmdbuf.c | 14 +-
> drivers/gpu/drm/vmwgfx/vmwgfx_cmdbuf_res.c | 8 +-
> drivers/gpu/drm/vmwgfx/vmwgfx_context.c | 6 +-
> drivers/gpu/drm/vmwgfx/vmwgfx_cotable.c | 3 +-
> drivers/gpu/drm/vmwgfx/vmwgfx_drv.c | 8 +-
> drivers/gpu/drm/vmwgfx/vmwgfx_execbuf.c | 20 +-
> drivers/gpu/drm/vmwgfx/vmwgfx_fence.c | 18 +-
> drivers/gpu/drm/vmwgfx/vmwgfx_ioctl.c | 2 +-
> drivers/gpu/drm/vmwgfx/vmwgfx_kms.c | 16 +-
> drivers/gpu/drm/vmwgfx/vmwgfx_kms.h | 4 +-
> drivers/gpu/drm/vmwgfx/vmwgfx_ldu.c | 4 +-
> drivers/gpu/drm/vmwgfx/vmwgfx_msg.c | 2 +-
> drivers/gpu/drm/vmwgfx/vmwgfx_overlay.c | 16 +-
> drivers/gpu/drm/vmwgfx/vmwgfx_resource.c | 10 +-
> drivers/gpu/drm/vmwgfx/vmwgfx_scrn.c | 10 +-
> drivers/gpu/drm/vmwgfx/vmwgfx_shader.c | 10 +-
> drivers/gpu/drm/vmwgfx/vmwgfx_so.c | 1 +
> drivers/gpu/drm/vmwgfx/vmwgfx_stdu.c | 9 +-
> drivers/gpu/drm/vmwgfx/vmwgfx_surface.c | 17 +-
> drivers/gpu/drm/vmwgfx/vmwgfx_thp.c | 1 +
> drivers/gpu/drm/vmwgfx/vmwgfx_ttm_buffer.c | 2 +
> drivers/gpu/drm/vmwgfx/vmwgfx_validation.c | 5 +-
> include/drm/drm_atomic.h | 3 +-
> 44 files changed, 818 insertions(+), 847 deletions(-)
>
> Cc: Alex Deucher <alexander.deucher@....com>
> Cc: amd-gfx@...ts.freedesktop.org
> Cc: Anthony Koo <Anthony.Koo@....com>
> Cc: Ben Skeggs <bskeggs@...hat.com>
> Cc: "Christian König" <christian.koenig@....com>
> Cc: Colin Ian King <colin.king@...onical.com>
> Cc: Daniel Vetter <daniel@...ll.ch>
> Cc: Dave Airlie <airlied@...hat.com>
> Cc: David Airlie <airlied@...ux.ie>
> Cc: dri-devel@...ts.freedesktop.org
> Cc: freedreno@...ts.freedesktop.org
> Cc: Harry Wentland <harry.wentland@....com>
> Cc: Jeremy Kolb <jkolb@...ndeis.edu>
> Cc: Kuogee Hsieh <khsieh@...eaurora.org>
> Cc: Lee Jones <lee.jones@...aro.org>
> Cc: Leo Li <sunpeng.li@....com>
> Cc: linaro-mm-sig@...ts.linaro.org
> Cc: linux-arm-msm@...r.kernel.org
> Cc: linux-media@...r.kernel.org
> Cc: Lyude Paul <lyude@...hat.com>
> Cc: Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>
> Cc: Maxime Ripard <mripard@...nel.org>
> Cc: nouveau@...ts.freedesktop.org
> Cc: Qinglang Miao <miaoqinglang@...wei.com>
> Cc: Rob Clark <rob.clark@...aro.org>
> Cc: Rob Clark <robdclark@...il.com>
> Cc: Roland Scheidegger <sroland@...are.com>
> Cc: Sean Paul <sean@...rly.run>
> Cc: Sumit Semwal <sumit.semwal@...aro.org>
> Cc: Thomas Zimmermann <tzimmermann@...e.de>
> Cc: VMware Graphics <linux-graphics-maintainer@...are.com>
> Cc: Zack Rusin <zackr@...are.com>
>
Powered by blists - more mailing lists