linux-kernel - Re: [PATCH] PCI: designware-ep: Fix NULL pointer dereference error

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 5 Mar 2021 10:19:35 -0600
From:   Rob Herring <robh@...nel.org>
To:     Kishon Vijay Abraham I <kishon@...com>
Cc:     Jingoo Han <jingoohan1@...il.com>,
        Gustavo Pimentel <gustavo.pimentel@...opsys.com>,
        Lorenzo Pieralisi <lorenzo.pieralisi@....com>,
        Bjorn Helgaas <bhelgaas@...gle.com>,
        PCI <linux-pci@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Lokesh Vutla <lokeshvutla@...com>
Subject: Re: [PATCH] PCI: designware-ep: Fix NULL pointer dereference error

On Thu, Mar 4, 2021 at 8:59 PM Kishon Vijay Abraham I <kishon@...com> wrote:
>
> commit 281f1f99cf3a ("PCI: dwc: Detect number of iATU windows") detected
> the number of inbound and outbound windows dynamically at runtime in
> dw_pcie_setup(). However pcie-designware-ep.c accessed the variables
> holding the number of inbound and outbound windows even before
> dw_pcie_setup() was invoked. Fix the sequence here.
>
> Fixes: 281f1f99cf3a ("PCI: dwc: Detect number of iATU windows")
> Signed-off-by: Kishon Vijay Abraham I <kishon@...com>
> ---
>  .../pci/controller/dwc/pcie-designware-ep.c   | 44 ++++++++++---------
>  1 file changed, 23 insertions(+), 21 deletions(-)

There's already another fix posted. I prodded Bjorn to apply it.

Rob