linux-kernel - Re: [PATCH V3 0/2] arm64/mm: Fix pfn_valid() for ZONE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 5 Mar 2021 13:16:28 -0500 (EST)
From:   Veronika Kabatova <vkabatov@...hat.com>
To:     Anshuman Khandual <anshuman.khandual@....com>,
        Will Deacon <will@...nel.org>
Cc:     linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
        linux-mm@...ck.org, Catalin Marinas <catalin.marinas@....com>,
        Ard Biesheuvel <ardb@...nel.org>,
        Mark Rutland <mark.rutland@....com>,
        James Morse <james.morse@....com>,
        Robin Murphy <robin.murphy@....com>,
        Jérôme Glisse <jglisse@...hat.com>,
        Dan Williams <dan.j.williams@...el.com>,
        David Hildenbrand <david@...hat.com>,
        Mike Rapoport <rppt@...ux.ibm.com>
Subject: Re: [PATCH V3 0/2] arm64/mm: Fix pfn_valid() for ZONE_DEVICE based
 memory



----- Original Message -----
> From: "Veronika Kabatova" <vkabatov@...hat.com>
> To: "Anshuman Khandual" <anshuman.khandual@....com>
> Cc: linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org, linux-mm@...ck.org, "Catalin Marinas"
> <catalin.marinas@....com>, "Will Deacon" <will@...nel.org>, "Ard Biesheuvel" <ardb@...nel.org>, "Mark Rutland"
> <mark.rutland@....com>, "James Morse" <james.morse@....com>, "Robin Murphy" <robin.murphy@....com>, "Jérôme Glisse"
> <jglisse@...hat.com>, "Dan Williams" <dan.j.williams@...el.com>, "David Hildenbrand" <david@...hat.com>, "Mike
> Rapoport" <rppt@...ux.ibm.com>
> Sent: Friday, March 5, 2021 1:28:40 PM
> Subject: Re: [PATCH V3 0/2] arm64/mm: Fix pfn_valid() for ZONE_DEVICE based memory
> 
> 
> 
> ----- Original Message -----
> > From: "Anshuman Khandual" <anshuman.khandual@....com>
> > To: linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
> > linux-mm@...ck.org
> > Cc: "Catalin Marinas" <catalin.marinas@....com>, "Will Deacon"
> > <will@...nel.org>, "Ard Biesheuvel" <ardb@...nel.org>,
> > "Mark Rutland" <mark.rutland@....com>, "James Morse" <james.morse@....com>,
> > "Robin Murphy" <robin.murphy@....com>,
> > "Jérôme Glisse" <jglisse@...hat.com>, "Dan Williams"
> > <dan.j.williams@...el.com>, "David Hildenbrand"
> > <david@...hat.com>, "Mike Rapoport" <rppt@...ux.ibm.com>, "Veronika
> > Kabatova" <vkabatov@...hat.com>
> > Sent: Friday, March 5, 2021 6:38:14 AM
> > Subject: Re: [PATCH V3 0/2] arm64/mm: Fix pfn_valid() for ZONE_DEVICE based
> > memory
> > 
> > 
> > On 3/5/21 10:54 AM, Anshuman Khandual wrote:
> > > This series fixes pfn_valid() for ZONE_DEVICE based memory and also
> > > improves
> > > its performance for normal hotplug memory. While here, it also
> > > reorganizes
> > > pfn_valid() on CONFIG_SPARSEMEM. This series is based on v5.12-rc1.
> > > 
> > > Cc: Catalin Marinas <catalin.marinas@....com>
> > > Cc: Will Deacon <will@...nel.org>
> > > Cc: Ard Biesheuvel <ardb@...nel.org>
> > > Cc: Mark Rutland <mark.rutland@....com>
> > > Cc: James Morse <james.morse@....com>
> > > Cc: Robin Murphy <robin.murphy@....com>
> > > Cc: Jérôme Glisse <jglisse@...hat.com>
> > > Cc: Dan Williams <dan.j.williams@...el.com>
> > > Cc: David Hildenbrand <david@...hat.com>
> > > Cc: Mike Rapoport <rppt@...ux.ibm.com>
> > > Cc: Veronika Kabatova <vkabatov@...hat.com>
> > > Cc: linux-arm-kernel@...ts.infradead.org
> > > Cc: linux-mm@...ck.org
> > > Cc: linux-kernel@...r.kernel.org
> > > 
> > > Changes in V3:
> > > 
> > > - Validate the pfn before fetching mem_section with __pfn_to_section() in
> > > [PATCH 2/2]
> > 
> > Hello Veronica,
> > 
> > Could you please help recreate the earlier failure [1] but with this
> > series applies on v5.12-rc1. Thank you.
> > 
> 
> Hello Anshuman,
> 
> the machine in question is currently loaned to a developer. I'll reach
> out to them and will let you know once I have any results.
> 

Hi,

I'm happy to report the kernel boots with these new patches. I used the
5.12.0-rc1 kernel (commit 280d542f6ffac0) as a base. The full console log
from the boot process is available at

https://gitlab.com/-/snippets/2086833

in case you want to take a look. Note that there are some call traces
starting around line 3220, but they are NOT introduced by these two
patches and are also present with the base mainline kernel.


Veronika

> 
> Veronika
> 
> > [1]
> > https://lore.kernel.org/linux-arm-kernel/cki.8D1CB60FEC.K6NJMEFQPV@redhat.com/
> > 
> > - Anshuman
> > 
> > 
>