linux-kernel - Re: [PATCH] dt-bindings: serial: stm32: add examples

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210305185347.GA466473@robh.at.kernel.org>
Date:   Fri, 5 Mar 2021 12:53:47 -0600
From:   Rob Herring <robh@...nel.org>
To:     Valentin Caron <valentin.caron@...s.st.com>
Cc:     Alexandre Torgue <alexandre.torgue@...s.st.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Maxime Coquelin <mcoquelin.stm32@...il.com>,
        Erwan Le Ray <erwan.leray@...s.st.com>,
        linux-serial@...r.kernel.org, devicetree@...r.kernel.org,
        linux-stm32@...md-mailman.stormreply.com,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] dt-bindings: serial: stm32: add examples

On Tue, Feb 09, 2021 at 10:59:48AM +0100, Valentin Caron wrote:
> From: Valentin Caron <valentin.caron@...com>
> 
> Add examples to show more use cases :
>  - uart2 with hardware flow control
>  - uart4 without flow control

Why do I need these? I can go read your dts files if I need more 
examples.

> 
> Signed-off-by: Valentin Caron <valentin.caron@...s.st.com>
> ---
>  .../bindings/serial/st,stm32-uart.yaml        | 20 +++++++++++++++++++
>  1 file changed, 20 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/serial/st,stm32-uart.yaml b/Documentation/devicetree/bindings/serial/st,stm32-uart.yaml
> index 06d5f251ec88..3a4aab5d1862 100644
> --- a/Documentation/devicetree/bindings/serial/st,stm32-uart.yaml
> +++ b/Documentation/devicetree/bindings/serial/st,stm32-uart.yaml
> @@ -82,6 +82,26 @@ additionalProperties: false
>  examples:
>    - |
>      #include <dt-bindings/clock/stm32mp1-clks.h>
> +
> +    usart4: serial@...04c00 {
> +      compatible = "st,stm32-uart";
> +      reg = <0x40004c00 0x400>;
> +      interrupts = <52>;
> +      clocks = <&clk_pclk1>;
> +      pinctrl-names = "default";
> +      pinctrl-0 = <&pinctrl_usart4>;
> +    };
> +
> +    usart2: serial@...04400 {
> +      compatible = "st,stm32-uart";
> +      reg = <0x40004400 0x400>;
> +      interrupts = <38>;
> +      clocks = <&clk_pclk1>;
> +      st,hw-flow-ctrl;
> +      pinctrl-names = "default";
> +      pinctrl-0 = <&pinctrl_usart2 &pinctrl_usart2_rtscts>;
> +    };
> +
>      usart1: serial@...11000 {
>        compatible = "st,stm32-uart";
>        reg = <0x40011000 0x400>;
> -- 
> 2.17.1
>