linux-kernel - Re: [PATCH v4 3/3] dt-bindings: arm: fsl: Add Variscite i.MX6UL compatibles

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210305213115.GA676128@robh.at.kernel.org>
Date:   Fri, 5 Mar 2021 15:31:15 -0600
From:   Rob Herring <robh@...nel.org>
To:     Oliver Graute <oliver.graute@...il.com>
Cc:     shawnguo@...nel.org, m.felsch@...gutronix.de, festevam@...il.com,
        narmstrong@...libre.com, Sascha Hauer <s.hauer@...gutronix.de>,
        Pengutronix Kernel Team <kernel@...gutronix.de>,
        NXP Linux Team <linux-imx@....com>,
        Krzysztof Kozlowski <krzk@...nel.org>,
        Oleksij Rempel <linux@...pel-privat.de>,
        Stefan Riedmueller <s.riedmueller@...tec.de>,
        Matthias Schiffer <matthias.schiffer@...tq-group.com>,
        Li Yang <leoyang.li@....com>, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH v4 3/3] dt-bindings: arm: fsl: Add Variscite i.MX6UL
 compatibles

On Sun, Feb 14, 2021 at 02:13:50PM +0100, Oliver Graute wrote:
> Add the compatibles for Variscite i.MX6UL compatibles
> 
> Signed-off-by: Oliver Graute <oliver.graute@...il.com>
> ---
> 
> Changelog:
> 
> v4:
>  - added missing 6 in i.MX6
> 
>  v3:
>  - rebased
> 
>  v2:
>  - renamed binding
>  - removed superflous "
> 
>  Documentation/devicetree/bindings/arm/fsl.yaml | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/Documentation/devicetree/bindings/arm/fsl.yaml b/Documentation/devicetree/bindings/arm/fsl.yaml
> index 297c87f..e67b622 100644
> --- a/Documentation/devicetree/bindings/arm/fsl.yaml
> +++ b/Documentation/devicetree/bindings/arm/fsl.yaml
> @@ -499,6 +499,7 @@ properties:
>                - technexion,imx6ul-pico-dwarf   # TechNexion i.MX6UL Pico-Dwarf
>                - technexion,imx6ul-pico-hobbit  # TechNexion i.MX6UL Pico-Hobbit
>                - technexion,imx6ul-pico-pi      # TechNexion i.MX6UL Pico-Pi
> +              - variscite,imx6ul-var-6ulcustomboard # i.MX6 UltraLite Carrier-board

Doesn't match your dts file. Plus looks like a lot of redundancy.

Run dtbs_checks and with W=1 and make sure you aren't adding more 
warnings. Lots will be from the base SoC dtsi, but feel free to fix some 
of those too.