linux-kernel - Re: [PATCH] hwrng: bcm2835: set quality to 1000

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 5 Mar 2021 07:26:29 +0100
From:   Álvaro Fernández Rojas <noltari@...il.com>
To:     Florian Fainelli <f.fainelli@...il.com>
Cc:     Nicolas Saenz Julienne <nsaenzjulienne@...e.de>,
        Herbert Xu <herbert@...dor.apana.org.au>,
        Andrew Lunn <andrew@...n.ch>, Matt Mackall <mpm@...enic.com>,
        Ray Jui <rjui@...adcom.com>,
        Scott Branden <sbranden@...adcom.com>,
        bcm-kernel-feedback-list@...adcom.com,
        Rikard Falkeborn <rikard.falkeborn@...il.com>,
        linux-crypto@...r.kernel.org, linux-rpi-kernel@...ts.infradead.org,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
        Stijn Tintel <stijn@...ux-ipv6.be>, ynezz@...e.cz
Subject: Re: [PATCH] hwrng: bcm2835: set quality to 1000

Hi Florian,

> El 4 mar 2021, a las 23:28, Florian Fainelli <f.fainelli@...il.com> escribió:
> 
> On 3/4/21 7:11 AM, Nicolas Saenz Julienne wrote:
>> On Wed, 2021-03-03 at 10:29 +0100, Álvaro Fernández Rojas wrote:
>>> Hi Herbert,
>>> 
>>>> El 3 mar 2021, a las 10:20, Herbert Xu <herbert@...dor.apana.org.au> escribió:
>>>> 
>>>> On Sat, Feb 20, 2021 at 08:12:45PM +0100, Álvaro Fernández Rojas wrote:
>>>>> 
>>>>> I ran rngtest and this is what I got:
>>>> 
>>>> This is meaningless except for sources that have not been whitened.
>>>> 
>>>> Your justification needs to be based on what the hardware does or
>>>> is documented to do.
>>> 
>>> Ok, so I guess that we’re never setting that value to anything since there’s
>>> no public documentation about that ¯\_(ツ)_/¯.
>> 
>> @Florian, is there a way you might be able to get the official value?
> 
> I will be looking into the documentation this weekend and let you know
> whether we can change the driver's quality accordingly.

Could you do that for iproc-rng200.c too?

> -- 
> Florian

Best regards,
Álvaro.