linux-kernel - Re: [PATCH] ANDROID: usb: core: Send uevent when USB TOPO layer over 6

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <YEHfuCFGSpm5ldl0@kroah.com>
Date:   Fri, 5 Mar 2021 08:37:28 +0100
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Chien Kun Niu <rickyniu@...gle.com>
Cc:     stern@...land.harvard.edu, erosca@...adit-jv.com,
        gustavoars@...nel.org, a.darwish@...utronix.de, oneukum@...e.com,
        Kyle Tso <kyletso@...gle.com>, linux-usb@...r.kernel.org,
        linux-kernel@...r.kernel.org, James Wei <jameswei@...gle.com>
Subject: Re: [PATCH] ANDROID: usb: core: Send uevent when USB TOPO layer over
 6

On Fri, Mar 05, 2021 at 03:17:37PM +0800, Chien Kun Niu wrote:
> Greg KH <gregkh@...uxfoundation.org> 於 2021年3月3日 週三 下午5:10寫道：
> >
> > On Wed, Mar 03, 2021 at 05:03:25PM +0800, Chien Kun Niu wrote:
> > > Hi , Greg
> > >
> > > What tool will "catch" this?  Where is that code located at?
> > > => I prepare merge the code to Android phone , so I used Android HLOS
> > > to catch this uevent.
> >
> > Very odd quoting style, perhaps you might want to read up on how to do
> > this properly at:
> >         https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
> >
> > > uevents are not for stuff like this, you are trying to send "error
> > > conditions" to userspace, please use the "proper" interfaces like this
> > > and not abuse existing ones.
> > > => Sorry , I am not sure what is the "proper" interfaces your mean.
> > >      Could you please give me more description?
> >
> > How does the kernel normally send error conditions that it detects in
> > hardware to userspace?
> >
> 
> I will create a sysfs attribute to record the hub status.
> If there is a new hub with over 6 USB TOPO layer connected, I will use
> the sysfs_notify to send the "error conditions" to userspace.
> Is it a proper interfaces to delivery "error conditions"?

Maybe, it all depends on what you are wanting to show here.  Try it out
and see, it's easier to review patches that you have shown work properly
for your use case than it is to try to discuss general issues.

thanks,

greg k-h