linux-kernel - [PATCH] scsi: ufs: Remove redundant WB enabling check in ufshcd_wb_toggle

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-Id: <20210305091253.314-1-zbestahu@gmail.com>
Date:   Fri,  5 Mar 2021 17:12:53 +0800
From:   Yue Hu <zbestahu@...il.com>
To:     martin.petersen@...cle.com, jejb@...ux.ibm.com,
        linux-scsi@...r.kernel.org
Cc:     alim.akhtar@...sung.com, avri.altman@....com,
        stanley.chu@...iatek.com, cang@...eaurora.org, beanhuo@...ron.com,
        jaegeuk@...nel.org, asutoshd@...eaurora.org,
        linux-kernel@...r.kernel.org, huyue2@...ong.com,
        zhangwen@...ong.com, zbestahu@....com
Subject: [PATCH] scsi: ufs: Remove redundant WB enabling check in ufshcd_wb_toggle_flush()

From: Yue Hu <huyue2@...ong.com>

Note that ufshcd_wb_toggle_flush() will be called only in
ufshcd_wb_config() which have already checked if WB is allowed.

Signed-off-by: Yue Hu <huyue2@...ong.com>
---
 drivers/scsi/ufs/ufshcd.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c
index 721f55d..2c49344 100644
--- a/drivers/scsi/ufs/ufshcd.c
+++ b/drivers/scsi/ufs/ufshcd.c
@@ -5484,8 +5484,7 @@ static inline int ufshcd_wb_toggle_flush(struct ufs_hba *hba, bool enable)
 	u8 index;
 	enum query_opcode opcode;
 
-	if (!ufshcd_is_wb_allowed(hba) ||
-	    hba->dev_info.wb_buf_flush_enabled == enable)
+	if (hba->dev_info.wb_buf_flush_enabled == enable)
 		return 0;
 
 	if (enable)
-- 
1.9.1