linux-kernel - Re: [PATCH 37/44] USB: serial/keyspan, drop unneeded forward declarations

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YEIDq4n7eSagyY9F@hovoldconsulting.com>
Date:   Fri, 5 Mar 2021 11:10:51 +0100
From:   Johan Hovold <johan@...nel.org>
To:     Greg KH <gregkh@...uxfoundation.org>
Cc:     Jiri Slaby <jslaby@...e.cz>, linux-serial@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 37/44] USB: serial/keyspan, drop unneeded forward
 declarations

On Wed, Mar 03, 2021 at 08:17:11PM +0100, Greg Kroah-Hartman wrote:
> On Tue, Mar 02, 2021 at 07:22:07AM +0100, Jiri Slaby wrote:
> > Forward declarations make the code larger, harder to follow and rewrite.
> > Harder as the declarations are often omitted from global changes. Remove
> > forward declarations which are not really needed, i.e. when the
> > definition of the function is before its first use.
> > 
> > Signed-off-by: Jiri Slaby <jslaby@...e.cz>
> > Cc: Johan Hovold <johan@...nel.org>
> > ---
> >  drivers/usb/serial/keyspan.c | 20 --------------------
> >  1 file changed, 20 deletions(-)
> 
> I'll let Johan take this through his tree:
> 
> Reviewed-by: Greg Kroah-Hartman <gregkh@...uxfoundation.org>

Thanks, I'll pick these two up next week.

Jiri, was there ever a cover letter to this series? It took a while for
all 44 (!) patches to hit the lists (or my inbox), but I never could
figure out whether there was an overall theme to it that made you post
it all as a single series in the first place.

Johan