linux-kernel - Re: [PATCH v8 3/3] perf vendor events arm64: Add "_" to the event name, which starts with a number

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b140182c-3250-8c28-c28a-9dc3cefc89a2@huawei.com>
Date:   Fri, 5 Mar 2021 11:09:20 +0000
From:   John Garry <john.garry@...wei.com>
To:     Shunsuke Nakamura <nakamura.shun@...itsu.com>, <will@...nel.org>,
        <mathieu.poirier@...aro.org>, <leo.yan@...aro.org>,
        <peterz@...radead.org>, <mingo@...hat.com>, <acme@...nel.org>,
        <mark.rutland@....com>, <alexander.shishkin@...ux.intel.com>,
        <jolsa@...hat.com>, <namhyung@...nel.org>
CC:     <linux-arm-kernel@...ts.infradead.org>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v8 3/3] perf vendor events arm64: Add "_" to the event
 name, which starts with a number

On 05/03/2021 10:18, Shunsuke Nakamura wrote:
> The perf parser does not support event names that start with a number.
> This patch adds "_" to the event name, which starts with a number.
> 
> Signed-off-by: Shunsuke Nakamura <nakamura.shun@...itsu.com>

I think that this can be folded into patch 2/3, and my reveiwed-by tag 
still stands for patch 2/3.

Thanks

> ---
>   .../pmu-events/arch/arm64/fujitsu/a64fx/other.json     | 10 +++++-----
>   1 file changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/tools/perf/pmu-events/arch/arm64/fujitsu/a64fx/other.json b/tools/perf/pmu-events/arch/arm64/fujitsu/a64fx/other.json
> index 68b8e46d6140..10c823ac26cc 100644
> --- a/tools/perf/pmu-events/arch/arm64/fujitsu/a64fx/other.json
> +++ b/tools/perf/pmu-events/arch/arm64/fujitsu/a64fx/other.json
> @@ -98,31 +98,31 @@
>     {
>       "PublicDescription": "This event counts every cycle that no instruction was committed, but counts at the time when commits MOVPRFX only.",
>       "EventCode": "0x190",
> -    "EventName": "0INST_COMMIT",
> +    "EventName": "_0INST_COMMIT",
>       "BriefDescription": "This event counts every cycle that no instruction was committed, but counts at the time when commits MOVPRFX only."
>     },
>     {
>       "PublicDescription": "This event counts every cycle that one instruction is committed.",
>       "EventCode": "0x191",
> -    "EventName": "1INST_COMMIT",
> +    "EventName": "_1INST_COMMIT",
>       "BriefDescription": "This event counts every cycle that one instruction is committed."
>     },
>     {
>       "PublicDescription": "This event counts every cycle that two instructions are committed.",
>       "EventCode": "0x192",
> -    "EventName": "2INST_COMMIT",
> +    "EventName": "_2INST_COMMIT",
>       "BriefDescription": "This event counts every cycle that two instructions are committed."
>     },
>     {
>       "PublicDescription": "This event counts every cycle that three instructions are committed.",
>       "EventCode": "0x193",
> -    "EventName": "3INST_COMMIT",
> +    "EventName": "_3INST_COMMIT",
>       "BriefDescription": "This event counts every cycle that three instructions are committed."
>     },
>     {
>       "PublicDescription": "This event counts every cycle that four instructions are committed.",
>       "EventCode": "0x194",
> -    "EventName": "4INST_COMMIT",
> +    "EventName": "_4INST_COMMIT",
>       "BriefDescription": "This event counts every cycle that four instructions are committed."
>     },
>     {
>