linux-kernel - Re: [PATCH 1/2] units: Add the HZ_PER

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 4 Mar 2021 17:21:20 -0800
From:   Andrew Morton <akpm@...ux-foundation.org>
To:     Daniel Lezcano <daniel.lezcano@...aro.org>
Cc:     Andy Shevchenko <andy.shevchenko@...il.com>,
        "rafael@...nel.org" <rafael@...nel.org>,
        Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        Lukasz Luba <lukasz.luba@....com>,
        open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/2] units: Add the HZ_PER_KHZ macro

On Thu, 4 Mar 2021 13:41:27 +0100 Daniel Lezcano <daniel.lezcano@...aro.org> wrote:

> > Also, why make them signed types?  Negative Hz is physically
> > nonsensical.  If that upsets some code somewhere because it was dealing
> > with signed types then, well, that code needed fixing anyway.
> > 
> > Ditto MILLIWATT_PER_WATT and friends, sigh.
> 
> At the first glance converting to unsigned long should not hurt the
> users of this macro.
> 
> The current series introduces the macro and its usage but by converting
> the existing type.
> 
> Is it ok if I send a separate series to change the units from L to UL?

That's the way to do it...